libsql/core: Fix Statement::execute() signature #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psarna
reviewed
Aug 8, 2023
haaawk
approved these changes
Aug 8, 2023
The JavaScript language bindings, for example, need a function for executing a SQL statement and getting the number of changed rows back. The rusqlite `execute()` function does just that so let's fix our function signature to be compatible. Fixes tursodatabase#246
penberg
force-pushed
the
fix-execute-signature
branch
from
8303a85 to
90431a2
Compare
MarinPostma
pushed a commit
that referenced
this pull request
Oct 17, 2023
255: packages: nuke packages/rust/libsql-client r=penberg a=psarna It lives under libsql/libsql-client-rs repo now. Co-authored-by: Piotr Sarna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JavaScript language bindings, for example, need a function for executing a SQL statement and getting the number of changed rows back. The rusqlite
execute()function does just that so let's fix our function signature to be compatible.Fixes #246