Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqld: add in process s3 for bottomless tests #741

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Conversation

LucioFranco
Copy link
Contributor

This adds in process mock s3 backend via the s3s crate. This allows us to run tests without requiring a user run minio or hook up their real aws account.

This adds in process mock s3 backend via the `s3s` crate. This allows us
to run tests without requiring a user run `minio` or hook up their real
aws account.
@LucioFranco
Copy link
Contributor Author

Related s3s PR Nugine/s3s#112

Copy link
Contributor

@MarinPostma MarinPostma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@LucioFranco LucioFranco enabled auto-merge December 1, 2023 14:34
@LucioFranco LucioFranco added this pull request to the merge queue Dec 1, 2023
Merged via the queue into main with commit 025090d Dec 1, 2023
@LucioFranco LucioFranco deleted the lucio/in-process-s3 branch December 1, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants