server: add config version and replica config update handling #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
changed the title
LucioFranco
force-pushed
the
lucio/config-session
branch
from
c8a4f09 to
bb53d21
Compare
LucioFranco
force-pushed
the
lucio/config-session
branch
from
4c84c4b to
221590c
Compare
MarinPostma
reviewed
Jan 15, 2024
| // We don't store the version in the sqlitedb due to the session token | ||
| // changed each time we start the primary, this will cause the replica to | ||
| // handshake again and get the latest config. | ||
| let (tx, _) = watch::channel(InnerConfig { version: 0, config }); |
There was a problem hiding this comment.
this is only ok for now, because we keep the config for all namespaces in memory at all time. When we allow the number of namespaces to grow, we'll want to tie the config's lifetime to the namespace's lifetime in memory, which won't work anymore. To keep in mind for when we implement that.
MarinPostma
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.