reset replica when injector detects potential corruption #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
force-pushed
the
replication-corruption
branch
from
9de4fc1 to
8766c09
Compare
psarna
reviewed
Jan 31, 2024
libsql-replication/src/replicator.rs
Outdated
| @@ -201,7 +201,7 @@ impl<C: ReplicatorClient> Replicator<C> { | |||
| let mut error_printed = false; | |||
| for _ in 0..HANDSHAKE_MAX_RETRIES { | |||
| tracing::info!("Attempting to perform handshake with primary."); | |||
| match self.client.handshake().await { | |||
| match dbg!(self.client.handshake().await) { | |||
| @@ -466,7 +466,9 @@ impl Connection for WriteProxyConnection<RpcStream> { | |||
| ) -> Result<B> { | |||
| let mut state = self.state.lock().await; | |||
|
|
|||
| dbg!(); | |||
There was a problem hiding this comment.
and here, and in a couple more places
| rpc::replication::{Frame, HelloRequest, HelloResponse, LogOffset}, | ||
| }; | ||
| use libsql_server::{ | ||
| config::{AdminApiConfig, DbConfig, RpcClientConfig, RpcServerConfig}, |
There was a problem hiding this comment.
wait, all those headers were missing? Or is it the IDE getting too eager with fixing dependencies?
MarinPostma
force-pushed
the
replication-corruption
branch
from
8766c09 to
e631973
Compare
MarinPostma
force-pushed
the
replication-corruption
branch
from
e631973 to
860deb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we detect an error from the injector, we threat it a potential corruption, and reset the replica.