libsql: add periodic background sync #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarinPostma
reviewed
Feb 6, 2024
Comment on lines
+131
to
+145
| let jh = tokio::spawn( | ||
| async move { | ||
| loop { | ||
| if let Err(e) = replicator2.sync_oneshot().await { | ||
| tracing::error!("replicator sync error: {}", e); | ||
| } | ||
|
|
||
| tokio::time::sleep(sync_duration).await; | ||
| } | ||
| } | ||
| .instrument(tracing::info_span!("periodic_sync")), | ||
| ); | ||
|
|
||
| replicator.bg_abort = Some(Arc::new(DropAbort(jh.abort_handle()))); | ||
| } |
There was a problem hiding this comment.
would it make sense to spawn this task in a join set instead?
There was a problem hiding this comment.
That is an option, I think the behavior is the same here just saves us some code. So maybe we can refactor to that in the future.
LucioFranco
force-pushed
the
lucio/periodic-sync
branch
from
829ab2e to
565522a
Compare
This adds a new periodic sync configuration item to the `Builder` that will allow users to set a duration at which they want the background sync to sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new periodic sync configuration item to the
Builderthat will allow users to set a duration at which they want the background sync to sync.