-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a working example for tabs plugin with dropdown #35213
Conversation
ae97040
to
e1db80c
Compare
e1db80c
to
fb4b740
Compare
on the road atm so can't check in depth, but: we removed the "tab interface with dropdown" on purpose a few years ago because that pattern can't be expressed sensibly using ARIA, and because it's bad UX. i believe we even say so specifically in the documentation somewhere |
@patrickhlauke so, how do we proceed with this? I mean, if it's a bad practice, it doesn't make any sense to add it... |
my preference would be not to include it. we even have this already in the docs
maybe we could strengthen this from "should not" to "must not" or "can't" |
Agreed with @patrickhlauke — we should really avoid this. We may even promote this paragraph to a callout, I guess. |
Going to close this then. @patrickhlauke feel free to change the wording, although it looks like it's clear enough. So, perhaps we should make it a callout after all. |
following on from #35213 this - expands the note, making it clear it's not supported - makes it a callout
While working for #31443, I found that docs are missing a working example for the tabs plugin with dropdown (Since that PR is not working for tabs with dropdown). It is not that much required though but it covers one more use case with a working demo 🙂