Floating labels in input group: Border fix #36874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
force-pushed
the
main-lmp-floating-labels-border-fix
branch
from
21abc97 to
b17789e
Compare
mdo
approved these changes
Aug 1, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36868
The issue comes from #36759.
Problem explanation
From what I understand, the
.form-control/.form-selectis shifted of 1px compared to.form-floating(which is not shifted himself). So the content following.form-floatingis shifted of 1px compared to.form-floating. As we have the same shift inside and following.form-floating, the following content seems not to be shifted compared to the input.Solution
Shift the
.form-floatinghimself instead of its children.