Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List of activities is required when updating status #858

Closed
zeylahellyer opened this issue Jun 2, 2021 · 0 comments · Fixed by #891
Closed

List of activities is required when updating status #858

zeylahellyer opened this issue Jun 2, 2021 · 0 comments · Fixed by #891
Assignees
@7596ff
Labels
c-model Affects the model crate d-api Change related to Discord's API. m-breaking change Breaks the public API.

Comments

@zeylahellyer
Copy link
Member

A list of activities is required when updating the current user's status, per discord/discord-api-docs#2789. We currently have this wrapped in an Option.
@zeylahellyer zeylahellyer added c-model Affects the model crate m-breaking change Breaks the public API. d-api Change related to Discord's API. labels Jun 2, 2021
@7596ff 7596ff self-assigned this Jun 6, 2021
7596ff added a commit to 7596ff/twilight that referenced this issue Jun 6, 2021
@7596ff
chore!(gateway,http): activities is required when updating presence
706f957 
This PR removes the `Some` from `UpdateStatusInfo`, as the list is now
required. It also validates that at least one activity is present when
using the `new` method.

Fixes twilight-rs#858.
@7596ff 7596ff mentioned this issue Jun 6, 2021
Merged
@7596ff 7596ff linked a pull request Jun 6, 2021 that will close this issue
Activities is required when updating presence #891
Merged
Erk- pushed a commit that referenced this issue Jun 7, 2021
@7596ff
Activities is required when updating presence (#891)
ae6a5f5 
chore!(gateway,http): activities is required when updating presence

This PR removes the `Some` from `UpdateStatusInfo`, as the list is now
required. It also validates that at least one activity is present when
using the `new` method.

Fixes #858.
@7596ff 7596ff closed this as completed Jun 8, 2021
7596ff added a commit to 7596ff/twilight that referenced this issue Jun 13, 2021
@7596ff
chore!(gateway,http): activities is required when updating presence (t…
9c9762c 
…wilight-rs#891)

This PR removes the `Some` from `UpdateStatusInfo`, as the list is now
required. It also validates that at least one activity is present when
using the `new` method.

Fixes twilight-rs#858.
7596ff added a commit to 7596ff/twilight that referenced this issue Jun 13, 2021
@7596ff
chore!(gateway,http): activities is required when updating presence (t…
24823fd 
…wilight-rs#891)

This PR removes the `Some` from `UpdateStatusInfo`, as the list is now
required. It also validates that at least one activity is present when
using the `new` method.

Fixes twilight-rs#858.
7596ff added a commit to 7596ff/twilight that referenced this issue Jun 13, 2021
@7596ff
chore!(gateway,http): activities is required when updating presence (t…
6cc922a 
…wilight-rs#891)

This PR removes the `Some` from `UpdateStatusInfo`, as the list is now
required. It also validates that at least one activity is present when
using the `new` method.

Fixes twilight-rs#858.
7596ff added a commit to 7596ff/twilight that referenced this issue Jun 13, 2021
@7596ff
chore!(gateway,model): activities is required when updating presence (t…
3f0bbb2 
…wilight-rs#891)

This PR removes the `Some` from `UpdateStatusInfo`, as the list is now
required. It also validates that at least one activity is present when
using the `new` method.

Fixes twilight-rs#858.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@7596ff 7596ff

Labels
c-model Affects the model crate d-api Change related to Discord's API. m-breaking change Breaks the public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Activities is required when updating presence 7596ff/twilight
2 participants
@7596ff @zeylahellyer