enhancement!(gateway): rename zlib features #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the two zlib features - `stock-zlib` and `simd-zlib` - for consistency with other feature flags. These have been renamed to `zlib-stock` and `zlib-simd` to properly namespace the feature flags. Closes #717. BREAKING CHANGES: The gateway's `stock-zlib` and `simd-zlib` feature flags have been renamed to `zlib-stock` and `zlib-simd`, respectively. Signed-off-by: Vivian Hellyer <[email protected]>
zeylahellyer
added
t-docs
7596ff
approved these changes
May 22, 2021
AEnterprise
approved these changes
May 22, 2021
Erk-
approved these changes
May 22, 2021
7596ff
pushed a commit
to 7596ff/twilight
that referenced
this pull request
Jun 7, 2021
Rename the two zlib features - `stock-zlib` and `simd-zlib` - for consistency with other feature flags. These have been renamed to `zlib-stock` and `zlib-simd` to properly namespace the feature flags. Closes twilight-rs#717. BREAKING CHANGES: The gateway's `stock-zlib` and `simd-zlib` feature flags have been renamed to `zlib-stock` and `zlib-simd`, respectively.
7596ff
pushed a commit
to 7596ff/twilight
that referenced
this pull request
Jun 13, 2021
Rename the two zlib features - `stock-zlib` and `simd-zlib` - for consistency with other feature flags. These have been renamed to `zlib-stock` and `zlib-simd` to properly namespace the feature flags. Closes twilight-rs#717. BREAKING CHANGES: The gateway's `stock-zlib` and `simd-zlib` feature flags have been renamed to `zlib-stock` and `zlib-simd`, respectively.
7596ff
pushed a commit
to 7596ff/twilight
that referenced
this pull request
Jun 13, 2021
Rename the two zlib features - `stock-zlib` and `simd-zlib` - for consistency with other feature flags. These have been renamed to `zlib-stock` and `zlib-simd` to properly namespace the feature flags. Closes twilight-rs#717. BREAKING CHANGES: The gateway's `stock-zlib` and `simd-zlib` feature flags have been renamed to `zlib-stock` and `zlib-simd`, respectively.
7596ff
pushed a commit
to 7596ff/twilight
that referenced
this pull request
Jun 13, 2021
Rename the two zlib features - `stock-zlib` and `simd-zlib` - for consistency with other feature flags. These have been renamed to `zlib-stock` and `zlib-simd` to properly namespace the feature flags. Closes twilight-rs#717. BREAKING CHANGES: The gateway's `stock-zlib` and `simd-zlib` feature flags have been renamed to `zlib-stock` and `zlib-simd`, respectively.
7596ff
added a commit
that referenced
this pull request
Jun 13, 2021
Upgrade Path Replace `zlib` features with their new names. Create a `Cluster` or `Shard` like this: ```diff -let cluster = Cluster::new(token, intents).await?; -let mut events = cluster.events(); +let (cluster, mut events) = Cluster::new(token, intents).await?; ``` Replace references to `UpdateStatus` and `UpdateStatusInfo` with `UpdatePresence` and `UpdatePresencePayload` respectively. Ensure at least one `Activity` is present in `UpdatePresence`. Changes The `zlib` feature choices have been renamed from `'stock-zlib` and `simd-zlib` to `zlib-stock` and `zlib-simd` respectively ([#829] - [@vivian]). `Cluster::new`, `ClusterBuilder::build`, `Shard::new`, and `ShardBuilder::build` now return a tuple with two elements: the cluster or shard itself and a stream of events. See the PR for more details ([#832] - [@vivian]). `UpdateStatus` and `UpdateStatusInfo` have been renamed to `UpdatePresence` and `UpdatePresencePayload` respectively ([#902] - [@7596ff]). At least one `Activity` is required when building an `UpdatePresence` payload. `UpdatePresenceError` and `UpdatePresenceErrorType` have been created to validate this ([#891] - [@7596ff]). [#829]: #829 [#832]: #832 [#891]: #891 [#902]: #902 [@7596ff]: https://github.com/7596ff [@vivian]: https://github.com/vivian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the two zlib features -
stock-zlibandsimd-zlib- for consistency with other feature flags. These have been renamed tozlib-stockandzlib-simdto properly namespace the feature flags.Closes #717.