Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make sonar exclusions a variable to reuse this file #636

Merged
merged 5 commits into from
Sep 29, 2022
Merged

fix: Make sonar exclusions a variable to reuse this file #636

merged 5 commits into from
Sep 29, 2022

Conversation

AsabuHere
Copy link
Contributor

Fixes

DII-640
A short description of what this PR does.
Make sonar exclusions a variable to reuse this file and run with different coverage areas

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

charan678
charan678 approved these changes Sep 28, 2022
View reviewed changes
Copy link

@charan678 charan678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AsabuHere AsabuHere merged commit 27e220b into main Sep 29, 2022
@AsabuHere AsabuHere deleted the csharp_monorepo_setup branch September 29, 2022 16:09
Swimburger pushed a commit to Swimburger/twilio-csharp that referenced this pull request Dec 28, 2022
@AsabuHere @Swimburger
fix: Make sonar exclusions a variable to reuse this file (twilio#636)
dc89687 
* Make sonar exclusions and project name variables to reuse this file and run with different coverage areas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charan678 charan678 charan678 approved these changes

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AsabuHere @charan678 @childish-sambino