Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bidi_class_for as it stands now is very slow. A linear search and the multiple parseInt calls per character are to blame.
I ended up fixing the generated file directly for my own application. I've created a pull request with that file to show the changes that would ultimately have to happen when generating the javascript files.
The bidi_classes object is now a sorted array of ranges, and the bidi_class_for method performs a binary search to find the correct range.