MOD:delete the buildPath code and use k8s native. And add a configGetter struct. #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr is about two things.
kubefwd/pkg/fwdport/fwdport.go
Lines 62 to 67 in 8503882
kubefwd/pkg/fwdport/fwdport.go
Lines 174 to 178 in 8503882
just use the k8s native way is well.
replace this
kubefwd/pkg/fwdport/fwdport.go
Line 55 in 8503882
and change the way to get RESTClient with k8s native is better i think.
// restClient.Client.Timeout = 32
in fwdport.go#L55if we want to set the timeout, set here is well.
test in k8s v1.16.0