simulateTransaction #19

Dodecahedr0x · 2025-02-08T16:30:19Z

Addresses #23.

It seems that the way the LiteSVM works and how it's used in the code prevents mutating it. I'm trying to find a way to get to it but might have to make a PR to LiteSVM at some point.

Summary by CodeRabbit

New Features
- Enhanced transaction operations with asynchronous processing for improved responsiveness.
- Introduced advanced processing of transaction metadata to better support UI account displays.
Refactor
- Streamlined transaction configuration handling for more efficient operations.
Chores
- Updated dependency configuration to leverage additional integration features.

coderabbitai · 2025-02-08T16:30:25Z

Walkthrough

The pull request updates the litesvm dependency in Cargo.toml to include the "nodejs-internal" feature. In the RPC module, the simulate_transaction function signature is modified to return a BoxFuture for asynchronous processing, and send_transaction has been streamlined by simplifying its configuration handling. Additionally, a new function to transform transaction metadata into UI accounts has been introduced in the utils module, along with corresponding import adjustments to support related types.

Changes

File(s)	Change Summary
crates/core/Cargo.toml	Updated dependency declaration for litesvm to include the "nodejs-internal" feature.
crates/core/src/rpc/full.rs	Changed simulate_transaction to return a BoxFuture, refactored send_transaction to simplify config handling, and added new imports for transaction metadata transformation.
crates/core/src/rpc/utils.rs	Added new function transform_tx_metadata_to_ui_accounts to convert TransactionMetadata into UiInnerInstructions and updated imports for enhanced transaction metadata processing.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant RPC
    participant AsyncWorker
    Client->>RPC: simulate_transaction(meta, data, config)
    RPC->>AsyncWorker: Process simulation asynchronously
    AsyncWorker-->>RPC: Return RpcResponse result
    RPC-->>Client: Return BoxFuture wrapping result

sequenceDiagram
    participant Caller
    participant Utils
    Caller->>Utils: transform_tx_metadata_to_ui_accounts(meta)
    Utils-->>Caller: Return Vec<UiInnerInstructions>

Poem

I hopped through lines of updated code,
Where features bloom and async paths flowed.
With metadata turning into art so bright,
My rabbit paws dance in pure delight.
Cheers to clean changes and a tech-savvy flight! 🐰
Hop on, dear devs, into code delight!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0dc2e30 and 8857aca.

📒 Files selected for processing (1)

crates/core/src/rpc/full.rs (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

crates/core/src/rpc/full.rs

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: run_cargo_checks
GitHub Check: build

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

adpthegreat · 2025-02-08T17:05:54Z

Hey @Dodecahedr0x I just want to ask concerning your PRs , how did you test your methods? I'm getting the hang of the codebase but I just want more clarity , thanks

Dodecahedr0x · 2025-02-08T17:15:19Z

Hey @Dodecahedr0x I just want to ask concerning your PRs , how did you test your methods? I'm getting the hang of the codebase but I just want more clarity , thanks

Hey, I'm using postman for now, but it would be nice to have tests directly in the codebase

lgalabru · 2025-02-08T18:22:24Z

Setting up a robust testing infrastructure would be amazing, @adpthegreat is this something you think you could help with?

lgalabru · 2025-02-08T18:25:28Z

@MicaiahReid can help too, he has extensive experience with this.

Dodecahedr0x · 2025-02-08T19:43:51Z

I noticed the nodejs-internal feature of LiteSVM that exposes set_XXXmethods instead of with_XXX that enable mutating the svm without deeper changes. Along with some changes that update local accounts, this should conclude this feature

lgalabru · 2025-02-08T20:32:58Z

crates/core/src/rpc/full.rs

+            )
+            .await;
+
+            let mut state_writer = meta.get_state_mut()?;


Should we be mutating if we're simulating?

It's only to insert missing accounts using the fetched ones. Simulating uses an immutable reference of the SVM

# Conflicts: # crates/core/src/rpc/full.rs

wip: initial simulateTransaction implementation

0a1924a

feat: update missing local accounts

bdea5e5

Dodecahedr0x marked this pull request as ready for review February 8, 2025 19:43

lgalabru reviewed Feb 8, 2025

View reviewed changes

lgalabru force-pushed the main branch from 20b7777 to ce4caef Compare February 9, 2025 00:23

lgalabru added 2 commits February 8, 2025 21:28

Merge branch 'main' into feat/simulateTransaction

0dc2e30

# Conflicts: # crates/core/src/rpc/full.rs

chore: cargo fmt

8857aca

lgalabru merged commit 0d908af into main Feb 9, 2025
3 checks passed

lgalabru deleted the feat/simulateTransaction branch February 9, 2025 02:41

coderabbitai bot mentioned this pull request Feb 12, 2025

Cycling too fast #35

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

simulateTransaction #19

simulateTransaction #19

Dodecahedr0x commented Feb 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 8, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

adpthegreat commented Feb 8, 2025

Dodecahedr0x commented Feb 8, 2025

lgalabru commented Feb 8, 2025 •

edited

Loading

lgalabru commented Feb 8, 2025

Dodecahedr0x commented Feb 8, 2025

lgalabru Feb 8, 2025

Dodecahedr0x Feb 8, 2025

simulateTransaction #19

simulateTransaction #19

Conversation

Dodecahedr0x commented Feb 8, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai bot commented Feb 8, 2025 • edited Loading

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

adpthegreat commented Feb 8, 2025

Dodecahedr0x commented Feb 8, 2025

lgalabru commented Feb 8, 2025 • edited Loading

lgalabru commented Feb 8, 2025

Dodecahedr0x commented Feb 8, 2025

lgalabru Feb 8, 2025

Choose a reason for hiding this comment

Dodecahedr0x Feb 8, 2025

Choose a reason for hiding this comment

Dodecahedr0x commented Feb 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

lgalabru commented Feb 8, 2025 •

edited

Loading