fixes: get_signature_statuses implementation, epoch progress

[lgalabru]

Summary by CodeRabbit

• New Features
  • Enhanced transaction processing now clearly distinguishes between newly received and processed transactions.
  • Introduced an automatic mechanism to expire outdated data, boosting overall system reliability.

• Refactor
  • Streamlined the approach for retrieving transaction statuses, merging local lookup and remote fetching into a more efficient flow.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes refactor the processing of transaction signature statuses and update the transaction history state. In the RPC module, the get_signature_statuses method now distinguishes between signatures found locally and those requiring remote fetching by using separate vectors. In the simnet module, transaction states are encapsulated in the new EntryStatus enum with Received and Processed variants, and the GlobalState history field is updated accordingly. An additional method, expect_processed, is provided along with event handling logic for ExpireBlockHash. Overall, the modifications clarify control flow and state management.

Changes

File(s)	Change Summary
crates/core/src/rpc/full.rs	Added import for EntryStatus; refactored get_signature_statuses to use separate loops for local lookup and remote fetching, improving clarity in status handling.
crates/core/src/simnet/mod.rs	Introduced the EntryStatus enum (with Received and Processed variants) and expect_processed method; updated GlobalState history field; added handling for ExpireBlockHash event.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant F as Full Service
    participant LH as LocalHistory
    participant RF as RemoteFetcher

    C->>F: get_signature_statuses(list of signatures)
    loop For each signature
        F->>LH: Check local entry status
        alt Status Found
            LH-->>F: Return EntryStatus (Received/Processed)
        else Not Found
            F->>RF: Fetch transaction details
            RF-->>F: Return status details
        end
    end
    F->>C: Return aggregated statuses

Loading

sequenceDiagram
    participant T as Transaction
    participant GS as GlobalState
    participant P as Processor

    T->>GS: Insert transaction (set as Received)
    P->>GS: Process transaction and update status
    GS-->>P: Mark entry as Processed with metadata
    P->>GS: Call expect_processed()
    GS-->>P: Return TransactionWithStatusMeta

Loading

Possibly related PRs

• getTransaction #18: Updates similar logic in get_signature_statuses, reflecting a direct connection with the new status fetching approach.
• getSignatureStatuses #22: Modifies the get_signature_statuses method with changes to signature processing, highlighting related control flow updates.

Poem

I'm a rabbit with a code-hop beat,
Leaping through modules both swift and neat.
Signature statuses now clear as day,
Received or Processed – hip hip hooray!
With refactored logic and a playful cheer,
I celebrate new changes with a bunny ear!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25ed3a5 and 6722b11.

📒 Files selected for processing (2)

• crates/core/src/rpc/full.rs (3 hunks)
• crates/core/src/simnet/mod.rs (10 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.