Fix ValidationError false positive on nested inputs #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts parts of PR 909.
This was referenced Apr 28, 2022
Merged
sobolevn
approved these changes
Apr 28, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Regression from PR #909.
As previously discussed in #767 (comment),
ValidationErroraccepts arbitrarily nested data structures as themessageargument. Mypy does not currently support recursive type aliases, so AFAIK it's impossible to accurately describe the correct type of this. In any case, the current hints are not correct.For example this correct code from
django-rest-frameworkproduces a false positive error: https://github.com/encode/django-rest-framework/blob/3.13.1/tests/test_fields.py#L2428-L2433I don't have any better ideas other than to revert to my version from #767 that uses
Any.