Does not install git hooks when using yarn #84

Jflinchum · 2016-12-12T17:06:03Z

When running yarn add husky --dev, the git hooks do not get set up. I have to run the install script manually, and then it works fine.

Yarn version: 0.17.9

The text was updated successfully, but these errors were encountered:

SxMShaDoW · 2016-12-12T17:12:50Z

👍 on this functionality.

typicode · 2016-12-12T17:58:06Z

Thanks for the feedback.
Seems it does run husky's postinstall just once, except if you ignore cache by using --force.

/tmp$ rm .git/hooks/pre-commit
rm: cannot remove '.git/hooks/pre-commit': No such file or directory
/tmp$ yarn add --dev husky 
yarn add v0.17.10
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
└─ [email protected]
Done in 0.14s.
/tmp$ cat .git/hooks/pre-commit
cat: .git/hooks/pre-commit: No such file or directory
/tmp$ yarn add --dev husky --force
yarn add v0.17.10
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Rebuilding all packages...
success Saved lockfile.
success Saved 1 new dependency.
└─ [email protected]
Done in 0.75s.
/tmp$ cat .git/hooks/pre-commit
#!/bin/sh
# husky
cd .
...

avaly · 2017-02-15T13:02:06Z

Can this be addressed in a future version? Projects and teams using yarn should not need to manually run the --force command in order to get the functionality working.

typicode · 2017-02-15T14:48:44Z

Hi @avaly,

Yes it will.
I have a few ideas for this but need to do some testing.

elektronik2k5 · 2017-02-25T07:56:26Z

I've encountered a few issues with it too :(. Had to remove the hook manually from .git/hooks/ then yarn add husky --dev --force to make it work.

ahstro · 2017-03-13T10:44:11Z

I'm not experiencing this. Is it fixed? If so, close? :)

cs-miller · 2017-05-09T01:31:45Z

still experiencing this

erquhart · 2017-05-17T14:32:45Z

@typicode is this still in the works?

typicode · 2017-05-17T21:13:52Z

@erquhart did another test and yarn v0.24.5 seems to solve this issue

evenfrost · 2017-05-24T14:32:58Z

Just faced the same problem with yarn v0.24.5, same with fresh yarn cache (i.e. afteryarn cache clean). Only yarn add --dev husky --force helps.

Can be reproduced on my booted.

typicode · 2017-05-28T17:31:48Z

Hi @evenfrost,

Here's what I did to test:

/tmp$ mkdir A
/tmp$ cd A
/tmp/A$ git init && yarn init -y && yarn add husky --dev
Initialized empty Git repository in /private/tmp/A/.git/
yarn init v0.24.5
warning The yes flag has been set. This will automatically answer yes to all questions which may have security implications.
success Saved package.json
✨  Done in 0.07s.
yarn add v0.24.5
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 12 new dependencies.
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
└─ [email protected]
✨  Done in 0.86s.
/tmp/A$ cat .git/hooks/pre-commit
#!/bin/sh
#husky 0.13.4
# ...

/tmp/A$ cd ..
/tmp$ mkdir B
/tmp$ cd B
/tmp/B$ git init && yarn init -y && yarn add husky --dev
Initialized empty Git repository in /private/tmp/B/.git/
yarn init v0.24.5
warning The yes flag has been set. This will automatically answer yes to all questions which may have security implications.
success Saved package.json
✨  Done in 0.07s.
yarn add v0.24.5
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
[4/4] 📃  Building fresh packages...
success Saved lockfile.
success Saved 12 new dependencies.
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
└─ [email protected]
✨  Done in 0.78s.
/tmp/B$ cat .git/hooks/pre-commit
#!/bin/sh
#husky 0.13.4
# ...

I was able to make booted work with husky this way (git needs to be initialized first in the target directory):

/tmp$ mkdir booted-test
/tmp$ cd booted-test/
/tmp/booted-test$ git init
Initialized empty Git repository in /private/tmp/booted-test/.git/
/tmp/booted-test$ cd ..
/tmp$ ./node_modules/.bin/booted booted-test/
 ✔ Copying code...
 ✔ Installing packages with Yarn...
 ✔ Booted.
/tmp$ cd booted-test/
/tmp/booted-test$ cat .git/hooks/pre-commit
#!/bin/sh
#husky 0.13.3
# ...

evenfrost · 2017-05-29T10:04:11Z

Hmm weird, can confirm reproducing these steps manually fixed the issue for me. Will investigate my package workflow further, thanks @typicode.

philihp · 2018-09-20T21:33:14Z

@typicode Encountering this again.

Yarn 1.9.4
npm 6.4.1
node v8.11.4
husky1.0.0-rc.14

To get around this and force it, I added to my package.json's scripts:

  "postinstall": "node ./node_modules/husky/lib/installer/bin install"

hjemmel · 2019-02-13T17:43:47Z

Same problem here using 1.13.0 and latest version of husky

eduardoarandah · 2019-12-11T17:40:38Z

So google can find it for the next guy:

husky hooks not working manually install

Execute this in your command line:

node ./node_modules/husky/lib/installer/bin install

Nikodermus · 2020-02-21T01:18:48Z

Why is this closed? The actual issue is not solved, is still happening in:

yarn 1.22.0
node v13.7.0
husky ^4.2.3

When I try to run the above command, it fails:

node ./node_modules/husky/lib/installer/bin install
husky > Setting up git hooks
Cannot destructure property 'name' of 'which_pm_runs_1.default(...)' as it is undefined.
husky > Failed to install

Removing .git/hooks didn't work either, neither adding it as a postinstall script did

technoknol · 2020-03-14T10:15:11Z

For me it was git version. I've updated git version and it worked like charm. Make sure your git is > 2.13

lucadegasperi · 2020-04-01T13:12:41Z

Getting the same issue as @Nikodermus here's my setup:

yarn 1.22.4
node 12.16.0
husky ^4.2.3

allenGKC · 2020-04-23T05:37:36Z

Why is this closed? The actual issue is not solved, is still happening in:
yarn 1.22.0
node v13.7.0
husky ^4.2.3
When I try to run the above command, it fails:
node ./node_modules/husky/lib/installer/bin install
husky > Setting up git hooks
Cannot destructure property 'name' of 'which_pm_runs_1.default(...)' as it is undefined.
husky > Failed to install
Removing .git/hooks didn't work either, neither adding it as a postinstall script did

@Nikodermus Have you solved this problem?

allenGKC · 2020-04-23T06:12:19Z

@Nikodermus try this method #640 (comment)

Norserium · 2020-05-20T14:44:55Z

Installing the last Yarn version (1.22.4) and running command yarn add --dev husky --force solved this problem for me.

cat-walk · 2020-08-11T10:14:47Z

Why is this closed? The actual issue is not solved, is still happening in:
yarn 1.22.0
node v13.7.0
husky ^4.2.3
When I try to run the above command, it fails:
node ./node_modules/husky/lib/installer/bin install
husky > Setting up git hooks
Cannot destructure property 'name' of 'which_pm_runs_1.default(...)' as it is undefined.
husky > Failed to install
Removing .git/hooks didn't work either, neither adding it as a postinstall script did

using the version '3.1.0' solved my problem.

    "husky": "^3.1.0",

AndreaCitrolo · 2020-10-14T08:31:14Z

@cat-walk you are experiencing that issue because you are not running that command through yarn so the script cannot infer your package manager name, the error is not very explicative in this case. Try adding:

    "setuphusky": "node ./node_modules/husky/husky.js install"

to your package json and then run:

yarn run setuphusky

rossthedevigner · 2020-11-17T23:19:47Z

At version 5 (husky@latest) and I don't get the manual install either when using yarn install. Only on ^4.3.1

This documents how to enable git hooks after first install: `https://typicode.github.io/husky/#/?id=install` Normally you'd simply write `husky install`, but it failed for me (see issue typicode/husky#84 (comment)), so I replaced it with the equivalent long-form invocation, `node ./node_modules/husky/lib/installer/bin install`.

kabaros · 2020-11-26T18:06:54Z

for anyone having this issue with version 4 (which seems to also happen with npm 7), the solution for me was to run

INIT_CWD=.git/hooks node ./node_modules/husky/lib/installer/bin.js install

to force installing the hooks under .git/hooks

Xunnamius · 2020-11-27T23:26:33Z

Just chiming in to say I'm experiencing this as well with husky@4... on npm 7, as @kabaros alluded to. The only solution that worked for me was to upgrade to husky@5.

matsad3547 · 2021-02-12T21:26:04Z

I'm still having this issue:

yarn 1.22.5
node v14.12.0
husky ^5.0.9

after running yarn add --dev husky --force and cat .git/hooks/pre-commit I've still got cat: .git/hooks/pre-commit: No such file or directory

I've also tried running install.js directly from the command line via node ./node_modules/husky/lib/commands/install but that didn't work either. That's how the husky package is now structured; the above command errored for me.

chenasraf · 2021-02-18T16:08:54Z

The hooks won't get created for me either.

node 14.15.4
yarn 1.22.10
husky 5.0.9

The hooks won't run, install says it's successful but it doesn't create any hooks.

node_modules/.bin/husky install     
husky - Git hooks installed

But when I commit, it immediately proceeds without running anything.

package.json:

  "husky": {
    "hooks": {
      "pre-commit": "echo 'RUNNING HOOK!'"
    }
  }

johnhayesio · 2021-02-19T12:07:15Z

Same issue I have. I have removed and re-added husky without any change. I have also run the install file directly, but this doesn't do anything either. My versions are as follows:

node 14.15.2
yarn 1.22.10
husky 5.0.9

Same issues as @chenasraf .

chenasraf · 2021-02-19T13:34:52Z

Turns out husky v5 does not pull hooks from package.json anymore. You have to use husky add [hook-name] [command]

In my opinion, that's worse as it pollutes the tree with another set of plain script files, which contain the command itself, instead of abstracting the command into the runner... Also husky add doesn't always chmod the file properly, so it's more steps to make hooks work, plus they're uglier now.

matsad3547 · 2021-02-19T21:15:56Z

@chenasraf Doh! Missed that, thanks for pointing it out.

lauthieb · 2021-02-21T23:29:37Z

The hooks won't get created for me either.
node 14.15.4
yarn 1.22.10
husky 5.0.9
The hooks won't run, install says it's successful but it doesn't create any hooks.
node_modules/.bin/husky install     
husky - Git hooks installed
But when I commit, it immediately proceeds without running anything.

package.json:
  "husky": {
    "hooks": {
      "pre-commit": "echo 'RUNNING HOOK!'"
    }
  }

Same for us on https://github.com/decathlon/vitamin-web

typicode · 2021-02-22T19:58:48Z

Hi,

husky 5 has a breaking change regarding config, .huskyrc isn’t supported anymore. See docs for install or migration steps.

lauthieb · 2021-02-23T00:04:31Z

@typicode indeed, thanks!
Fixed: Decathlon/vitamin-web@29e3ef7
🎉

Noah-Krossa · 2021-02-28T10:37:15Z

Try to execute npx husky install after install husky like dev dependencie, this command substitute default git hooks by husky hooks.

jasan-s · 2021-03-20T05:28:12Z

using yarn --force also worked for me

srgg · 2021-03-25T08:26:29Z

I've spent a lot of time trying to figure out what is wrong, but the things are that they have changed the entire approach.

For those who are still struggling with this issue, and for newcomers: read Husky 5 Release announcement especially sections "Optional install" and "Config":

With husky 4, hooks were automatically installed. With husky 5, you have the choice and it’s explicit.

Moreover, from the "Config" section:

Previously, hooks were defined in package.json or .huskyrc. Now they’re defined directly in their corresponding hook file. Overhead is reduced and scripting is easier.

dammit..

99.9999% of existing materials described husky integration become trash..

chenasraf · 2021-03-25T08:29:13Z

Genuinely confused about the decision to remove support for config files, you could always link to your own scripts before, but now your are much more limited...

LuisValgoi · 2021-05-27T17:05:25Z

Fixed through:

  "scripts": {
    "postinstall": "node ./node_modules/husky/lib/bin install",
    "dev": "craco start",
    "build": "craco build",
    ...
  },
   ...
  "devDependencies": {
    ...
    "husky": "^6.0.0",
    ...
  },

taoliujun · 2021-10-20T12:42:12Z

It is not worked to me above all.
When husky > 5, just do it.

yarn add -D husky
add "postinstall": "husky install", into package.json scripts
run yarn run postinstall once.(just run after first install husky)
npx husky add .husky/pre-commit "npm run eslint"
remember add .husky into git

- https://blog.pumpkin-raccoon.com/85 - typicode/husky#84

ghost mentioned this issue Mar 5, 2017

There is a problem with yarn add husky --dev verekia/js-stack-from-scratch#145

Closed

berkin mentioned this issue Mar 8, 2017

yarn add husky --dev doesn't install git hooks verekia/js-stack-from-scratch#160

Closed

typicode closed this as completed May 21, 2017

nickytonline mentioned this issue Sep 6, 2017

precommit npm script not running after installing minobo a second time from a fresh clone nickytonline/generator-minobo#1

Closed

shirakaba mentioned this issue Nov 25, 2020

Ensure that Husky git hooks are installed after first install NativeScript/plugin-seed#10

Merged

se030 added a commit to boostcampwm-2022/web27-Wabinar that referenced this issue Nov 11, 2022

add: husky pre-commit hook 추가

f601365

- https://blog.pumpkin-raccoon.com/85 - typicode/husky#84

Does not install git hooks when using yarn #84

Does not install git hooks when using yarn #84

Comments

Jflinchum commented Dec 12, 2016

SxMShaDoW commented Dec 12, 2016

typicode commented Dec 12, 2016

avaly commented Feb 15, 2017

typicode commented Feb 15, 2017

elektronik2k5 commented Feb 25, 2017

ahstro commented Mar 13, 2017

cs-miller commented May 9, 2017

erquhart commented May 17, 2017

typicode commented May 17, 2017 • edited Loading

evenfrost commented May 24, 2017 • edited Loading

typicode commented May 28, 2017

evenfrost commented May 29, 2017

philihp commented Sep 20, 2018

hjemmel commented Feb 13, 2019

eduardoarandah commented Dec 11, 2019

husky hooks not working manually install

Nikodermus commented Feb 21, 2020 • edited Loading

technoknol commented Mar 14, 2020

lucadegasperi commented Apr 1, 2020

allenGKC commented Apr 23, 2020

allenGKC commented Apr 23, 2020

Norserium commented May 20, 2020

cat-walk commented Aug 11, 2020

AndreaCitrolo commented Oct 14, 2020

rossthedevigner commented Nov 17, 2020 • edited Loading

kabaros commented Nov 26, 2020 • edited Loading

Xunnamius commented Nov 27, 2020 • edited Loading

matsad3547 commented Feb 12, 2021

chenasraf commented Feb 18, 2021

johnhayesio commented Feb 19, 2021

chenasraf commented Feb 19, 2021 • edited Loading

matsad3547 commented Feb 19, 2021

lauthieb commented Feb 21, 2021

typicode commented Feb 22, 2021

lauthieb commented Feb 23, 2021

Noah-Krossa commented Feb 28, 2021 • edited Loading

jasan-s commented Mar 20, 2021

srgg commented Mar 25, 2021 • edited Loading

chenasraf commented Mar 25, 2021

LuisValgoi commented May 27, 2021 • edited Loading

taoliujun commented Oct 20, 2021

typicode commented May 17, 2017 •

edited

Loading

evenfrost commented May 24, 2017 •

edited

Loading

Nikodermus commented Feb 21, 2020 •

edited

Loading

rossthedevigner commented Nov 17, 2020 •

edited

Loading

kabaros commented Nov 26, 2020 •

edited

Loading

Xunnamius commented Nov 27, 2020 •

edited

Loading

chenasraf commented Feb 19, 2021 •

edited

Loading

Noah-Krossa commented Feb 28, 2021 •

edited

Loading

srgg commented Mar 25, 2021 •

edited

Loading

LuisValgoi commented May 27, 2021 •

edited

Loading