Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create extend.json #325

Merged
merged 1 commit into from
Apr 18, 2016
Merged

Create extend.json #325

merged 1 commit into from
Apr 18, 2016

Conversation

unional
Copy link
Member

@unional unional commented Apr 17, 2016

Filling in these fields will make it easier for us to review:

Typings URL: [E.g. http://github.com/typed-typings/npm-extend]
Source URL: [E.g. https://github.com/justmoon/node-extend]

Thanks for contributing!

@Fank
Copy link
Member

Fank commented Apr 17, 2016

source url is 404

@unional
Copy link
Member Author

unional commented Apr 17, 2016

Ar, corrected.

@blakeembrey
Copy link
Member

Did you consider using intersection types instead?

@unional
Copy link
Member Author

unional commented Apr 17, 2016

Did you consider using intersection types instead?

What do have in mind? Intersecting the two function signatures?

Have yet to see the benefit in this scenario.

@blakeembrey
Copy link
Member

Whichever you want, I suppose. This would be 100x more useful if TypeScript gets "outer sections" or whatever the latest proposal is.

@blakeembrey
Copy link
Member

LGTM 👍

@unional
Copy link
Member Author

unional commented Apr 17, 2016

This would be 100x more useful if TypeScript gets "outer sections" or whatever the latest proposal is.

Which proposal are you referring to? Would like to learn about it.

@blakeembrey
Copy link
Member

I can't recall a complete proposal, just saw hints around and a real need for it to achieve better type safety. E.g. microsoft/TypeScript#6895.

@unional unional merged commit 439fb99 into master Apr 18, 2016
@unional unional deleted the unional-patch-1 branch April 18, 2016 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants