Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Bitwuzla has changed it's command line argument format #716

Closed
Gallagator opened this issue Feb 20, 2024 · 1 comment · Fixed by #721
Closed

Bitwuzla has changed it's command line argument format #716

Gallagator opened this issue Feb 20, 2024 · 1 comment · Fixed by #721

Comments

@Gallagator
Copy link
Contributor

Gallagator commented Feb 20, 2024

After trying to see why my bitwuzla tests were failing, I noticed it wasn't parsing the command line arguments properly.
The arguments in question are here: https://github.com/ucb-bar/chiseltest/blob/main/src/main/scala/chiseltest/formal/backends/smt/SMTLibSolver.scala#L37

--incremental needs to be removed according to this:
https://github.com/bitwuzla/bitwuzla/blob/bed6d6ed270ef94c3f2db8f03c892deec25c2a8d/NEWS.md?plain=1#L209

smt2 is now specified as --lang smt2 - see: https://github.com/bitwuzla/bitwuzla/blob/bed6d6ed270ef94c3f2db8f03c892deec25c2a8d/NEWS.md?plain=1#L68

Should we update the command line options along with the CI?

@Gallagator Gallagator changed the title Bitwuzla has changed it's commandline argument format Bitwuzla has changed it's command line argument format Feb 20, 2024
@ekiwi
Copy link
Collaborator

ekiwi commented Feb 23, 2024

Should we update the command line options along with the CI?

Ideally we would support both the old and the new arguments. It is annoying, but we might have to do one of two things:

  1. call bitwuzla --version, parse the string to determine which options to use
  2. use the new options first, if bitwuzla returns an error, use the old options

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants