Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JPIP options to Travis configuration #692

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stweil
Copy link
Contributor

@stweil stweil commented Jan 9, 2016

No description provided.

@stweil
Copy link
Contributor Author

stweil commented Jan 9, 2016

I don't expect that this will work immediately, because there might be missing build dependencies (Java, more?). Maybe the JPIP server should be added later in a 2nd step.

@stweil
Copy link
Contributor Author

stweil commented Jan 9, 2016

The automated checks failed because of issue #658. I'll now add pull request #659 here. Hopefully the checks will pass then.

@stweil
Copy link
Contributor Author

stweil commented Jan 14, 2016

Most checks are now successful.

Travis fails with clang (MacOSX) and x86_64-w64-mingw32-gcc (Windows cross) compilers. I assume that those build environments are incomplete. How can I see what is missing for JPIP?

@mayeut
Copy link
Collaborator

mayeut commented Jan 14, 2016

You can see some things in CDASH: http://my.cdash.org/index.php?project=OPENJPEG&date=2016-01-09

@stweil
Copy link
Contributor Author

stweil commented Jan 14, 2016

@mayeut, thanks. http://my.cdash.org/buildSummary.php?buildid=890011 contains the log messages for MacOSX, http://my.cdash.org/buildSummary.php?buildid=890008 those for Windows.

The pull request here is ok: it detects faulty code in the JPIP library. Several format strings are not portable and fail for MacOSX and 64 bit Windows.

I suggest to pull #659 - that fixes a precondition for JPIP. Then the format string problem can be addressed. Hopefully all checks will work then and #692 can be pulled.

@mayeut
Copy link
Collaborator

mayeut commented May 10, 2016

@stweil, I merged #659 , I did not see that @malaterre said it was ok to merge, sorry about the delay. Can you rebase this one please ?

@stweil
Copy link
Contributor Author

stweil commented May 11, 2016

@mayeut, the patch is rebased now. 2 of the 4 original commits were no longer needed.

stweil added 2 commits July 9, 2016 16:32
This fixes issue uclouvain#691.

Signed-off-by: Stefan Weil <[email protected]>
It has build dependencies which are missing on the Travis server.

Signed-off-by: Stefan Weil <[email protected]>
@stweil
Copy link
Contributor Author

stweil commented Jul 9, 2016

@mayeut, the PR was now rebased once more. Could you please pull it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants