Skip to content

Commit

Permalink
fix: pin to wdio^8 for now
Browse files Browse the repository at this point in the history
* chore: pin to wdio^8 until we assert compatibility with wdio^9
* chore(deps): minor and patch version bumps
* docs: welcome simon
* fix: type declaration
* chore: fix typos and src comments
merging even though auth tests fail, but they are a false positive.
  • Loading branch information
vobu authored Aug 24, 2024
1 parent 676ab16 commit 0ae7e8d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ It is used for end-to-end tests of a UI5 web-application.

`wdi5` is governed by a fine group of people deciding on strategy and next steps for the tool (in alphabetical order of last name):

- Arnaud Buchholz [@ArnaudBuchholz](https://github.com/ArnaudBuchholz)
- Simon Coen [@Siolto](https://github.com/Siolto)
- Dominik Feininger [@dominikfeininger](https://github.com/dominikfeininger)
- Constantin Lebrecht [@monavari-lebrecht](https://github.com/monavari-lebrecht)
- Hristo Manchev [@hmanchev](https://github.com/hmanchev)
Expand All @@ -26,6 +26,7 @@ It is used for end-to-end tests of a UI5 web-application.

Thank you for having accompanied our journey! 🏅

- Arnaud Buchholz [@ArnaudBuchholz](https://github.com/ArnaudBuchholz) - July 2022..August2024
- Peder Hveem Alsvik [@ph-alsvik](https://github.com/ph-alsvik) - July 2022..October 2022
- Nicholas O'Malley [@aiopa](https://github.com/aiopa) - October 2022..October 2023

Expand Down
8 changes: 4 additions & 4 deletions src/lib/wdi5-bridge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ function initBrowser(browserInstance: WebdriverIO.Browser) {
function checkUI5Version(ui5Version: string) {
if (semver.lt(ui5Version, "1.60.0")) {
// the record replay api is only available since 1.60
Logger.error("The ui5 version of your application is to low. Minimum required UI5 version is 1.60")
throw new Error("The ui5 version of your application is to low. Minimum required UI5 version is 1.60")
Logger.error("The UI5 version of your application is too low. Minimum required is 1.60!")
throw new Error("The UI5 version of your application is too low. Minimum required is 1.60!")
}
}

Expand Down Expand Up @@ -258,11 +258,11 @@ export async function _addWdi5Commands(browserInstance: WebdriverIO.Browser) {
Logger.info(`creating internal control with id ${internalKey}`)
wdi5Selector.wdio_ui5_key = internalKey

marky_mark("retrieveSingleControl")
marky_mark("retrieveSingleControl") //> TODO: bind to debug log level

const wdi5Control = await new WDI5Control({ browserInstance }).init(wdi5Selector, wdi5Selector.forceSelect)

const e = marky_stop("retrieveSingleControl")
const e = marky_stop("retrieveSingleControl") //> TODO: bind to debug log level
Logger.info(`_asControl() needed ${e.duration} for ${internalKey}`)

browserInstance._controls[internalKey] = wdi5Control
Expand Down
4 changes: 2 additions & 2 deletions src/lib/wdi5-object.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ export class WDI5Object {
this._aProtoFunctions = aProtoFunctions
this._attachObjectMethods(this._aProtoFunctions)
} else {
Logger.warn(`[WANING] creating object: ${uuid} without functions`)
Logger.warn(`creating object: ${uuid} without functions`)
}

if (object) {
this._baseObject = object
this._attachObjectProperties(this._baseObject)
} else {
Logger.warn(`[WANING] creating object: ${uuid} without properties`)
Logger.warn(`creating object: ${uuid} without properties`)
}
}

Expand Down

0 comments on commit 0ae7e8d

Please sign in to comment.