-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check failed: exports->Lookup(name).IsTheHole(isolate) #348
Comments
Hi, this doesn't look like it's related to |
We investigated a bit and it seems to be related to some wdi5 logging core that, when requires, breaks node... very strange issue indeed |
I just tried to reproduce your issue. But for me it seems to work perfectly fine: npx wdio config
=========================
WDIO Configuration Helper
=========================
? Where is your automation backend located? On my local machine
? Which framework do you want to use? cucumber
? Do you want to use a compiler? No!
? Where are your feature files located? ./features/**/*.feature
? Where are your step definitions located? ./features/step-definitions/steps.js
? Do you want WebdriverIO to autogenerate some test files? Yes
? Do you want to use page objects (https://martinfowler.com/bliki/PageObject.html)? Yes
? Where are your page objects located? ./features/pageobjects/**/*.js
? Which reporter do you want to use? spec, cucumber-json
? Do you want to add a plugin to your test setup? wait-for
? Do you want to add a service to your test setup? chromedriver, ui5
? What is the base url? https://sapui5.hana.ondemand.com
? Do you want me to run `npm install` Yes
Installing wdio packages:
- @wdio/local-runner
- @wdio/cucumber-framework
- @wdio/spec-reporter
- wdio-cucumberjs-json-reporter
- wdio-wait-for
- wdio-chromedriver-service
- wdio-ui5-service
- chromedriver
npx wdio run wdio.conf.js
PASSED in chrome - /features/login.feature
2022-09-22T19:59:08.842Z INFO @wdio/cli:launcher: Run onWorkerEnd hook
2022-09-22T19:59:08.842Z INFO @wdio/cli:launcher: Run onComplete hook
"spec" Reporter:
------------------------------------------------------------------
[chrome 105.0.5195.125 mac os x #0-0] Running: chrome (v105.0.5195.125) on mac os x
[chrome 105.0.5195.125 mac os x #0-0] Session ID: d1fce942c904c0e7f7109b04e287b2b1
[chrome 105.0.5195.125 mac os x #0-0]
[chrome 105.0.5195.125 mac os x #0-0] » /features/login.feature
[chrome 105.0.5195.125 mac os x #0-0] The Internet Guinea Pig Website
[chrome 105.0.5195.125 mac os x #0-0] As a user, I can log into the secure area
[chrome 105.0.5195.125 mac os x #0-0] ✓ Given I am on the login page
[chrome 105.0.5195.125 mac os x #0-0] ✓ When I login with tomsmith and SuperSecretPassword!
[chrome 105.0.5195.125 mac os x #0-0] ✓ Then I should see a flash message saying You logged into a secure area!
[chrome 105.0.5195.125 mac os x #0-0]
[chrome 105.0.5195.125 mac os x #0-0] As a user, I can log into the secure area
[chrome 105.0.5195.125 mac os x #0-0] ✓ Given I am on the login page
[chrome 105.0.5195.125 mac os x #0-0] ✓ When I login with foobar and barfoo
[chrome 105.0.5195.125 mac os x #0-0] ✓ Then I should see a flash message saying Your username is invalid!
[chrome 105.0.5195.125 mac os x #0-0]
[chrome 105.0.5195.125 mac os x #0-0] 6 passing (3.2s)
Spec Files: 1 passed, 1 total (100% completed) in 00:00:07
2022-09-22T19:59:08.843Z INFO @wdio/local-runner: Shutting down spawned worker
2022-09-22T19:59:09.095Z INFO @wdio/local-runner: Waiting for 0 to shut down gracefully
2022-09-22T19:59:09.095Z INFO @wdio/local-runner: shutting down
The only difference is that I did not selected the Regards, |
@Siolto :The version was a typo. My bad :) |
I cleaned up the Node_modules and tried again. |
Hi @nair-sumesh, yes I have the steps.js // not really BDD style but it works
When("Cucumber Test", async () => {
const selector = await browser.asControl({
selector: {
id: "sdk---app--headerToolbar"
}
})
await expect(await selector.isInitialized()).toBeTruthy();
}) feature file
[chrome 105.0.5195.125 mac os x #0-0] Running: chrome (v105.0.5195.125) on mac os x
[chrome 105.0.5195.125 mac os x #0-0] Session ID: 9e9d28c4eb3a49454dc43d81492d0047
[chrome 105.0.5195.125 mac os x #0-0]
[chrome 105.0.5195.125 mac os x #0-0] » /features/login.feature
[chrome 105.0.5195.125 mac os x #0-0] Cucumber Test
[chrome 105.0.5195.125 mac os x #0-0] Cucumber Test
[chrome 105.0.5195.125 mac os x #0-0] ✓ When Cucumber Test
[chrome 105.0.5195.125 mac os x #0-0]
[chrome 105.0.5195.125 mac os x #0-0] 1 passing (1.7s)
Spec Files: 1 passed, 1 total (100% completed) in 00:00:07 Regards, |
And are you at node version v16.17.0. |
Yes I am at |
Steps to replicate
Observation
|
hey 👋 - silence for 30 days 🤐 ... anybody? 😀 |
hey 👋 |
Hi @nair-sumesh, sorry for the late response. The chromedriver is currently outdated so I have to update the devDependencies. But what I found in your reference project is that you don't have the required Regards, |
Hi @Siolto , I don't think that should be the reason. Best Regards, |
I am keen to compare the working test for Cucumber with my version. Best Regards, |
Hi @nair-sumesh, after investigating a little bit more and by finally being able to reproduce your issue I probably found a solution. Could you please add Why this dependency, in this specific combination, is needed needs to be checked. Regards, |
Thanks @Siolto. It worked. |
after investigating further with @vobu, we found a name clash with the cucumber framework. We will create a fix for that and automatically close this ticket when the fix is merged. |
closes #348 context: when wdi5 is used with cucumber instead of mocca, node runtime dumped during test execution. this was due to cucumber using the npm module "console" which caused a namespace/scope conflict w/ wdi5's own enhancement of the global console object * refactor: use dynamic import depending on node version * refactor: console scope Co-authored-by: Volker Buzek <[email protected]>
could you please |
scratch that, we just verified: bug still exists. gnarf. sorry :( |
With
1) with below version (manually adjusted
|
ok, we‘ll pull back/revert 1.0.4 until we get this issue under control. |
deprecated |
Describe the bug
It is not possible to use "wdio-ui5-service" with cucumber framework.
To Reproduce
Steps to reproduce the behavior:
npx wdio config
npx wdio run ./wdio.conf.js
Expected behavior
Sample Cucumber feature test should run successfully.
Logs/Console Output
Runtime Env (please complete the following information):
wdi5/wdio-ui5-service
-version: 1.1.5UI5
version: Doesn't matterwdio
-version (output ofwdio --version
): [e.g. 7.16.12]node
-version (output ofnode --version
): v16.17.0Regards,
-SN
The text was updated successfully, but these errors were encountered: