test + fix for allControls with forceSelect

docs/contributing.md

@@ -27,7 +27,7 @@ $> npm run build
 $> npm run build:watch
 ```
 
-Then to work on a test:  
+Then to work on a test:
 ...in terminal 1:
 
 ```shell
@@ -106,6 +106,10 @@ All browser-scope commands (such as `browser.asControl()`) are provided with `/s
 
 Given the continous build watch is running (`npm run build:watch`), hack away at any part!
 
+### instantiation
+
+![wdi5 control instantiation](./wdi5-control-instantiation.png)
+
 ## work on a test
 
 recommended approach:
@@ -160,17 +164,17 @@ some more text
 optional 1-line footer
 ```
 
-Please don't look at the above as restrictions, but rather as conventions: it helps to provide a harmonized codebase, both formatting- and code-style wise. And the coventional commits allow for automtically generating a `CHANGELOG.md` that we all benefit from ("what's new in version ....?").  
+Please don't look at the above as restrictions, but rather as conventions: it helps to provide a harmonized codebase, both formatting- and code-style wise. And the coventional commits allow for automtically generating a `CHANGELOG.md` that we all benefit from ("what's new in version ....?").
 Also, all of this combined aids tremendously in cutting automated releases - so new features or fixes can be published quickly!
 
 Please issue your Pull Requests against the `main` branch of the repository.
 
 ## work on the docs
 
-All documentation is written in `markdown` and lives in `/docs`.  
+All documentation is written in `markdown` and lives in `/docs`.
 [`Docsify` is used](https://docsify.js.org/#/) for running the documentation GitHub pages site <https://js-soft.github.io/wdi5>. It can easily be used to also run locally to work and preview the documentation site.
 
-Install it globally: `$> npm i -g docsify-cli`  
+Install it globally: `$> npm i -g docsify-cli`
 Then serve the `docs` dir: `$> docsify serve ./docs`
 
 This will run the documentation site including live reload on <http://localhost:3000>

examples/ui5-js-app/webapp/test/e2e/aggregation.test.js

@@ -25,7 +25,7 @@ describe("ui5 aggregation retrieval", () => {
 
         // shorthand getContent()
         const content = await page.getContent()
-        expect(content.length).toBe(2)
+        expect(content.length).toBe(3)
 
         // shorthand getContent($atIndex)
         const firstContentItem = await page.getContent(0)
@@ -37,7 +37,7 @@ describe("ui5 aggregation retrieval", () => {
 
         // regular getAggregation($name)
         const aggregation = await page.getAggregation("content")
-        expect(aggregation.length).toBe(2)
+        expect(aggregation.length).toBe(3)
 
         const listIdViaAggregationItem = await aggregation[0].getId()
         const vboxIdViaAggregationItem = await aggregation[1].getId()

examples/ui5-js-app/webapp/test/e2e/allControlsForce.test.js

@@ -0,0 +1,33 @@
+const Other = require("./pageObjects/Other")
+
+const oCheckboxSelector = {
+    forceSelect: true,
+    selector: {
+        controlType: "sap.m.CheckBox",
+        viewName: "test.Sample.view.Other"
+    }
+}
+
+describe("ui5 basic, get all buttons", () => {
+    before(async () => {
+        await Other.open()
+    })
+
+    it("test with multiple checkboxes", async () => {
+        const aCheckbox = await browser.allControls(oCheckboxSelector)
+
+        expect(aCheckbox.length).toEqual(9)
+
+        for await (let oCheckbox of aCheckbox) {
+            const selected = await oCheckbox.getSelected()
+            // console.log(`oCheckbox: ${oCheckbox.getControlInfo().id} isSelected: ${selected} `)
+            if (!selected) {
+                await oCheckbox.press()
+            }
+        }
+
+        for await (let oCheckbox of aCheckbox) {
+            expect(await oCheckbox.getSelected()).toBeTruthy()
+        }
+    })
+})

examples/ui5-js-app/webapp/view/Other.view.xml

@@ -27,6 +27,18 @@
 					text="add Line Item"
 					press=".onAddLineItem" />
 			</VBox>
+
+			<List id="PeopleListSelect"
+				headerText="People List with CheckBox"
+				items="{/Employees}">
+				<CustomListItem>
+					<HBox>
+						<CheckBox
+							text="{FirstName} {LastName}"
+							select="onSelect" />
+					</HBox>
+				</CustomListItem>
+			</List>
 		</content>
 	</Page>
 </mvc:View>

src/lib/wdi5-control.ts

@@ -183,7 +183,7 @@ export class WDI5Control {
      * this method is also used wdi5-internally to implement the extended forceSelect option
      */
     async renewWebElementReference() {
-        const newWebElement = (await this.getControl())[0]
+        const newWebElement = (await this.getControl({ selector: { id: this._domId } }))[0] // added to have a more stable retrieval experience
         this._webElement = newWebElement
         return newWebElement
     }
@@ -457,6 +457,8 @@ export class WDI5Control {
             // only if the result is valid
             this._webdriverRepresentation = await $(`//*[@id="${result[2]}"]`)
             this._generatedWdioMethods = this._retrieveControlMethods(this._webdriverRepresentation)
+
+            this._domId = result[2]
         }
 
         this.writeResultLog(result, "getControl()")