Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 引入 unplugin-svg-component 插件代替 vite-plugin-svg-icons 插件 & elIcon 支持类型提示 #220

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

heavenly-zy
Copy link
Contributor

相比原 vite-plugin-svg-icons 方案的好处如下:

  1. icon name 具有类型提示,且无需手动书写维护类型定义
  2. svg 图标自动优化去色,也可手动配置 svgo 配置进行优化
  3. 提供了 preserveColor 配置,支持定义保留原有颜色 SVG 目录(适用于存放多色图标),原 vite-plugin-svg-icons 插件做不到这一点
  4. svg 文件的增删改操作都能进行热更新

@pany-ang
Copy link
Member

👍🏻

@pany-ang
Copy link
Member

你似乎没有执行 pnpm i

@heavenly-zy
Copy link
Contributor Author

你似乎没有执行 pnpm i

执行了,只是 lock 文件我没上传

@pany-ang
Copy link
Member

你似乎没有执行 pnpm i

执行了,只是 lock 文件我没上传

为什么,我看你新增了依赖,应该要上传才对?

@heavenly-zy
Copy link
Contributor Author

你似乎没有执行 pnpm i

执行了,只是 lock 文件我没上传

为什么,我看你新增了依赖,应该要上传才对?

那我上传一下吧,之前我一直都是忽略上传 lock 文件的

@pany-ang pany-ang changed the title feat: svg 图标自动优化去色 & SvgIcon 组件名称支持类型提示 feat: 引入 unplugin-svg-component 插件代替 vite-plugin-svg-icons 插件 & elIcon 支持类型提示 Dec 2, 2024
@pany-ang pany-ang merged commit ebb8e80 into un-pany:5.x Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants