Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 7210/Fix problem the resources being clobbered #7211

Merged
merged 6 commits into from
Jan 10, 2022

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Jan 10, 2022

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

  • test with build below
  1. delete your ~/translationCore/resources folder
  2. start app and after app has started:
  • check ugnt versions at ~/translationCore/resources/el-x-koine/bibles/ugnt and should see two versions:

Screen Shot 2022-01-10 at 11 07 34 AM

  • delete the latest version v0.22

  • check hbo versions at ~/translationCore/resources/hbo/bibles/uhb and should see two versions:
    Screen Shot 2022-01-10 at 11 09 25 AM

  • delete the latest version v2.1.23

  • check for content updates and download latest resources for hbo and el-x-koine

  • make sure that old version is not deleted on new resource download:

  • check ugnt versions at ~/translationCore/resources/el-x-koine/bibles/ugnt and should see two versions:
    Screen Shot 2022-01-10 at 11 07 34 AM

  • check hbo versions at ~/translationCore/resources/hbo/bibles/uhb and should see two versions:
    Screen Shot 2022-01-10 at 11 09 25 AM

  • close tC and launch again.

  • make sure that old version is not deleted when restarting app:

  • check ugnt versions at ~/translationCore/resources/el-x-koine/bibles/ugnt and should see two versions:
    Screen Shot 2022-01-10 at 11 07 34 AM

  • check hbo versions at ~/translationCore/resources/hbo/bibles/uhb and should see two versions:
    Screen Shot 2022-01-10 at 11 09 25 AM

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story
  • Ask Ben or Koz if you have any concerns about implementation (especially UI related)

This change is Reviewable

@PhotoNomad0 PhotoNomad0 changed the base branch from release-v3.0.2 to release-v3.1.0 January 10, 2022 15:03
@PhotoNomad0 PhotoNomad0 changed the title WIP: Bugfix 7210 WIP: Bugfix 7210/Fix problem the resources being clobbered Jan 10, 2022
@PhotoNomad0 PhotoNomad0 changed the title WIP: Bugfix 7210/Fix problem the resources being clobbered Bugfix 7210/Fix problem the resources being clobbered Jan 10, 2022
@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review January 10, 2022 21:22
Copy link
Contributor

@mannycolon mannycolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mannycolon mannycolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PhotoNomad0)

@mannycolon mannycolon merged commit 8d50789 into release-v3.1.0 Jan 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the bugfix-mcleanb-7210 branch January 10, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants