Split out capi targets: make separate freertos, staticlib, and cdylib crates as targets #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
commented
Mar 29, 2022
ffi/diplomat/Cargo.toml
Outdated
| @@ -47,6 +47,9 @@ provider_static = ["icu_testdata"] | |||
| smaller_static = ["provider_static"] | |||
| # Enables size-optimized builds on x86_64 | |||
| x86tiny = ["dlmalloc"] | |||
| # We can't exclude x86tiny from `--all-features` and it messes up the build for other crates | |||
| # Instead, we use this feature to detect when `--all-features` is occurring | |||
| internal_all_features_hack = [] | |||
There was a problem hiding this comment.
We don't really have a good way to opt out of --all-features
sffc
requested changes
Mar 29, 2022
sffc
previously approved these changes
Mar 29, 2022
sffc
previously approved these changes
Mar 29, 2022
sffc
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to vendor things without pulling in freertos deps, and also is a less weird-looking workaround to rust-lang/cargo#4881