Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_std + alloc support #55

Merged
merged 10 commits into from
Apr 10, 2020
Merged

Add no_std + alloc support #55

merged 10 commits into from
Apr 10, 2020

Conversation

Dentosal
Copy link
Contributor

@Dentosal Dentosal commented Apr 9, 2020

This pull request adds no_std + alloc support behind a feature flag, closing issue #15. It also updates tinyvec dependency, migrates code to 2018 edition of Rust and runs rustfmt on the codebase. Tests for both std and no_std versions are added to .travis.yml.

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please do these as separate commits?

Cargo.toml Outdated

[features]
default = ["std"]
std = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline at eof please

@Dentosal
Copy link
Contributor Author

Dentosal commented Apr 9, 2020

Separated to multiple commits, and added the missing newline

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mod tables should have a #[rustfmt::skip], it's autogenerated and i'd prefer to have it be easily diffable

@Dentosal
Copy link
Contributor Author

Added relevant #[rustfmt::skip] attributes.

@Manishearth
Copy link
Member

No, please add it to the entire module, that file is generated and should not be manually edited. Please add it to the mod tables; in lib.rs

@Dentosal Dentosal force-pushed the master branch 2 times, most recently from 5c3d0eb to 0c85b51 Compare April 10, 2020 18:51
@Dentosal
Copy link
Contributor Author

Dentosal commented Apr 10, 2020

Done. I edited both the script and src/tables.rs manually, because https://www.unicode.org has been down for a few days now. The changes should still be identical.

The travis check seems to fail because of a network timeout when installing Rust.

@Manishearth
Copy link
Member

There is still rustfmt::skip on individual items in tables.rs

@Dentosal
Copy link
Contributor Author

Fixed

Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Manishearth Manishearth merged commit 20679bc into unicode-rs:master Apr 10, 2020
@Dentosal
Copy link
Contributor Author

Thanks for patience. Please close issue #15 as this fixes it.

@Manishearth Manishearth linked an issue Apr 10, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add core-only/nostd feature
2 participants