Ruby: delete rspec related kinds #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close universal-ctags#453. (This is about a bug spotted in universal-ctags#453 by @mislav and in universal-ctags#11 by @NewAlexandria.) Kinds C and d are for Rspec. Parts of code related to above kinds assume a ruby string comes after Rspec keywords (describe or context). This is a wrong assumption. A class name can be used there. It is nice if ctags can handle these rspec code well, but we don't have enough resource to make it now. So in this commit I delete rspec related code temporary. I just reserve a kind letter 'd' for rspec for the future. 'C' is completely deleted because (1) describe and context have the same meaning in rspec, and (2) we would like to assign 'C' for Ruby constant as ripper-tags does. Signed-off-by: Masatake YAMATO <[email protected]>
masatake
added a commit
that referenced
this pull request
Nov 27, 2015
Ruby: delete rspec related kinds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is about a bug spotted in #453 by @mislav and in #11 by
@NewAlexandria.)
Kinds C and d are for Rspec.
Parts of code related to above kinds assume a ruby string
comes after Rspec keywords (describe or context).
This is a wrong assumption. A class name can be used there.
It is nice if ctags can handle these rspec code well, but we
don't have enough resource to make it now.
So in this commit I delete rspec related code temporary. I
just reserve a kind letter 'd' for rspec for the future. 'C'
is completely deleted because (1) describe and context have
the same meaning in rspec, and (2) we would like to assign
'C' for Ruby constant as ripper-tags does.
Signed-off-by: Masatake YAMATO [email protected]