Skip to content

Commit

Permalink
fix(trimming): Disable XAML trimming on mono+OSX/Linux
Browse files Browse the repository at this point in the history
  • Loading branch information
jeromelaban authored Jan 12, 2023
1 parent e0fe6df commit 0442a1a
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions src/SourceGenerators/Uno.UI.Tasks/Content/Uno.UI.Tasks.targets
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
<PropertyGroup>
<UnoUIMSBuildTasksPath Condition="'$(UnoUIMSBuildTasksPath)'==''">Uno.UI.Tasks</UnoUIMSBuildTasksPath>
<UmbrellaMSBuildTasksImported>true</UmbrellaMSBuildTasksImported>

<_IsXamlTrimmingAvailable>true</_IsXamlTrimmingAvailable>
<_IsXamlTrimmingAvailable Condition="'$(MSBuildRuntimeType)'!='Core' and !$([MSBuild]::IsOSPlatform('windows'))">false</_IsXamlTrimmingAvailable>
</PropertyGroup>

<ItemGroup>
Expand Down Expand Up @@ -147,15 +150,16 @@
</Target>

<!--
XAML ResouTrimming
XAML Resources Trimming
-->

<Target Name="_UnoLinkerHintsSubstitutionsMerge"
Condition="
'$(DesignTimeBuild)' != 'true'
and '$(BuildingInsideUnoSourceGenerator)' == ''
and '$(SkipCompilerExecution)' == ''
and '$(UnoXamlResourcesTrimming)'=='true'"
and '$(UnoXamlResourcesTrimming)'=='true'
and $(_IsXamlTrimmingAvailable)"
AfterTargets="CoreCompile">

<ItemGroup>
Expand Down Expand Up @@ -184,7 +188,8 @@
'$(DesignTimeBuild)' != 'true'
and '$(BuildingInsideUnoSourceGenerator)' == ''
and '$(SkipCompilerExecution)' == ''
and ('$(UnoXamlResourcesTrimming)'=='true' or '$(UnoRewriteEmbeddedResources)'=='true')"
and ('$(UnoXamlResourcesTrimming)'=='true' or '$(UnoRewriteEmbeddedResources)'=='true')
and $(_IsXamlTrimmingAvailable)"
AfterTargets="@(_UnoEmbeddedResourcesInjectionAfterTargets)">

<ItemGroup>
Expand All @@ -202,7 +207,10 @@
</Target>

<Target Name="_UnoLinkerHintsPass1"
Condition="'$(IsUnoHead)'=='true' and '$(UnoXamlResourcesTrimming)'=='true'"
Condition="
'$(IsUnoHead)'=='true'
and '$(UnoXamlResourcesTrimming)'=='true'
and $(_IsXamlTrimmingAvailable)"
BeforeTargets="BuildDist;PrepareForILLink">

<ItemGroup>
Expand Down

0 comments on commit 0442a1a

Please sign in to comment.