fix: Increase HighMemoryThreshold for Samples app

unoplatform · Dec 14, 2022 · 7719e11 · 7719e11
1 parent afc81e0
commit 7719e11
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/SamplesApp/SamplesApp.Shared/App.xaml.cs b/src/SamplesApp/SamplesApp.Shared/App.xaml.cs
@@ -506,6 +506,9 @@ static void ConfigureFeatureFlags()
 #if __SKIA__
 			Uno.UI.FeatureConfiguration.ToolTip.UseToolTips = true;
 #endif
+
+			// Allow template pool to work under higher memory load for CI.
+			FrameworkTemplatePool.HighMemoryThreshold = 0.9f;
 		}
 
 

diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ComboBox.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ComboBox.cs
@@ -132,6 +132,11 @@ public async Task When_ComboBox_Constrained_By_Parent()
 			}
 		}
 
+		/// <remarks>
+		/// This test is memory sensitive - if the memory usage exceeds FrameworkTemplatePool.HighMemoryThreshold,
+		/// the test will most likely faily as the template will be recycled. Currently the Samples app uses
+		/// HighMemoryThreshold of 0.9 (see App.ConfigureFeatureFlags).
+		/// </remarks>
 		[TestMethod]
 #if __MACOS__
 		[Ignore("Currently fails on macOS, part of #9282 epic")]