fix(template): Move app.xaml.cs to shared "AppBase" #11085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/solution-templates
|
The build 67530 found UI Test snapshots differences: Details
|
dansiegel
suggested changes
Jan 29, 2023
There was a problem hiding this comment.
This is heading down the right path as far as having an application in the multi-targeted library to make it easier to manage. Since it's WinUI that's the real issue here I think we probably should do a couple of things.
- Name the App class in the multi-targeted project simply App
- We shouldn't need anything on the platform heads for the Uno side. But for WinUI we can simply provide an empty
WinApp.xamlthat inherits from our App class in the multi-targeted project. That way we have something in the WinUI project to provide an ApplicationDefinition for. We could code gen it, but really it will be an empty file that is easier to just place in the template for now.
|
@dansiegel Uno also needs the |
|
The build 67647 found UI Test snapshots differences: Details
|
|
The build 67664 found UI Test snapshots differences: Details
|
jeromelaban
force-pushed
the
dev/jela/template-adjust-app
branch
from
83d7d51 to
16134f7
Compare
|
The build 67719 found UI Test snapshots differences: Details
|
github-actions
bot
added
the
area/code-generation
|
The build 67745 found UI Test snapshots differences: Details
|
jeromelaban
force-pushed
the
dev/jela/template-adjust-app
branch
from
df46621 to
a6242c4
Compare
|
The build 67809 found UI Test snapshots differences: Details
|
agneszitte
reviewed
Jan 31, 2023
doc/articles/guides/silverlight-migration/03-review-app-startup.md
Outdated
Show resolved
Hide resolved
src/SolutionTemplate/UnoSolutionTemplate.WinUI.netcore/Base/AppHead.xaml.cs
Outdated
Show resolved
Hide resolved
src/SolutionTemplate/UnoSolutionTemplate.WinUI.netcore/Views/App.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Agnès ZITTE <[email protected]>
github-actions
bot
added
platform/android 🤖
|
The build 67877 found UI Test snapshots differences: Details
|
|
@Mergifyio backport release/stable/4.7 |
✅ Backports have been created
|
jeromelaban
added a commit
that referenced
this pull request
Feb 1, 2023
…4.7/pr-11085 fix(template): Move app.xaml.cs to shared "AppBase" (backport #11085)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): #11082, closes #11122
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Introduces an AppBase.cs class to provide access to the main App instance from the class library's code.
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):