fix: Fix DataContext lost on second HR on Android #19524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform/android 🤖
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19524/index.html |
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19524/index.html |
|
@Mergifyio backport release/stable/5.6 |
✅ Backports have been created
|
jeromelaban
approved these changes
Feb 14, 2025
src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.Common.cs
Outdated
Show resolved
Hide resolved
kazo0
approved these changes
Feb 14, 2025
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19524/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19524/index.html |
ajpinedam
approved these changes
Feb 14, 2025
|
|
carldebilly
approved these changes
Feb 14, 2025
|
The build 155100 found UI Test snapshots differences: Details
|
6 tasks
jeromelaban
added a commit
that referenced
this pull request
Feb 17, 2025
…5.6/pr-19524 fix: Fix DataContext lost on second HR on Android (backport #19524)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/unoplatform/private/issues/611
closes https://github.com/unoplatform/private/issues/612
closes https://github.com/unoplatform/private/issues/617
closes https://github.com/unoplatform/private/issues/624
closes https://github.com/unoplatform/private/issues/645
Bugfix
Fix
DataContextlost on second HR on AndroidWhat is the current behavior?
As
Framedoes not allow easy update ofContent, on HR we inject new instance (Page_v2) asContentof previous instance (Page_v1). We also flushDataContextofPage_v1to make sure 2-way bindings are no longer triggered.The issue is that on second HR (
Page_v3) as thePage_v1is still present in the tree, it matches (novelty of HR w/o cnomua) and is being used to clone properties toPage_v3, driving to clone an emptyDataContext.What is the new behavior?
We no longer clean the
DataContext, so subsequent clones are still working. This should not have any impact for 2-way binding as anyway theContentof the original instance is being replaced by a new instance.PR Checklist
Screenshots Compare Test Runresults.