Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix TextBox.Foreground on Skia #7352

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Oct 18, 2021

GitHub Issue (If applicable): closes #7172

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

  • On Skia, we update Foreground only for the DisplayBlock (appears only when unfocused)
  • On Skia WPF, we only support SolidColorBrush

What is the new behavior?

  • Update Foreground properly for both the input widget and the DisplayBlock.
  • Support more brushes on WPF.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Youssef1313 Youssef1313 requested a review from a team October 18, 2021 17:01
@gitpod-io
Copy link

gitpod-io bot commented Oct 18, 2021

@jeromelaban
Copy link
Member

Thanks for your contribution!

@jeromelaban jeromelaban merged commit 4ecf3b8 into unoplatform:master Nov 23, 2021
@Youssef1313 Youssef1313 deleted the issues/7172 branch November 23, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gallery][Skia.GTK] Textbox, Passwordbox, Combobox, Binding , text is not displaying correctly in night mode.
2 participants