Add checkAtMost parameter to getMostAllowedBlocked #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see upstash/core-analytics#38 for more details
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ogzhanolguncu
previously approved these changes
Jul 19, 2024
ogzhanolguncu
approved these changes
Jul 19, 2024
|
Is the v2 release a breaking change? Couldn't see anything in the release notes saying so |
|
We updated what the Looking back now, I think releasing a major version for this was maybe not the best course of action. We could have kept it backwards compatible and added a new method. At least it should be very easy to upgrade to 2.0.0 :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see upstash/core-analytics#38 for more details
should be merged after core-analytics PR is merged and core-analytics patch is released.