metamask: ensure expected chain ID #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, it was possible to have Metamask connected to another EVM chain (e.g. Optimism), or a testnet (e.g. Goerli) while using Mainnet Bridge. This resolves #1082 by conducting a check for the expected chain ID in the connected wallet during Login, and requesting to update it if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Before this change, it was possible to have Metamask connected to another EVM chain (e.g. Optimism), or a testnet (e.g. Goerli) while using Mainnet Bridge. This resolves #1082 by conducting a check for the expected chain ID in the connected wallet during Login, and requesting to update it if necessary.
Preview
bridge_ensure_chain_id-2022-12-12_04.44.20.mp4