Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default coefficient of ImplicitSourceTerm to 1 #984

Merged
merged 8 commits into from
Dec 13, 2023
Merged

Change default coefficient of ImplicitSourceTerm to 1 #984

merged 8 commits into from
Dec 13, 2023

Conversation

guyer
Copy link
Member

@guyer guyer commented Dec 7, 2023 •
edited
Loading

Fixes #512
Addresses #983

@guyer
Copy link
Member Author

guyer commented Dec 7, 2023

  • Failures with nix are because nix is... nix
  • Failures with macos-py3k-petsc(-parallel) appear to be because of a bump in conda petsc, (without a corresponding bump in petsc4py?): 
    142c145
<   - petsc=3.20.2=real_h4e83fda_100
---
>   - petsc=3.20.2=real_hfe9574a_102
    I will figure out how to freeze working prerequisites for all but the nightly builds, but, in the meantime, I think this can be ignored for this PR.

@guyer guyer requested review from wd15 and tkphd December 7, 2023 21:08
wd15
wd15 reviewed Dec 7, 2023
View reviewed changes
tkphd
tkphd approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@tkphd tkphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says on the tin.

@guyer guyer merged commit 0c88c9e into master Dec 13, 2023
@guyer guyer deleted the issue512-Default_coefficient_of_ImplicitSourceTerm_is_0 branch December 13, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wd15 wd15 wd15 approved these changes

@tkphd tkphd tkphd approved these changes

Assignees
No one assigned
Labels
bug terms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default coefficient of ImplicitSourceTerm is 0
3 participants
@guyer @wd15 @tkphd