Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guarantee v7 timestamp will never overflow #811

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Guarantee v7 timestamp will never overflow #811

merged 1 commit into from
Feb 26, 2025

Conversation

KodrAus
Copy link
Member

@KodrAus KodrAus commented Feb 26, 2025

Follow-up to #809

This PR just ensures that we don't accidentally overflow any values when constructing v7 UUIDs. Our behavior at the edges is to saturate rather than wrap, but we're free to pick whatever semantics we like here. This is really just closing a completeness hole rather than addressing any real use-cases.

@KodrAus KodrAus merged commit f05b6df into main Feb 26, 2025
21 checks passed
@KodrAus KodrAus deleted the fix/v7-overflow branch February 26, 2025 08:13
kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Feb 27, 2025
Bumps uuid from 1.15.0 to 1.15.1.

Release notes
Sourced from uuid's releases.

v1.15.1
What's Changed

Guarantee v7 timestamp will never overflow by @​KodrAus in uuid-rs/uuid#811
Prepare for 1.15.1 release by @​KodrAus in uuid-rs/uuid#812

Full Changelog: uuid-rs/[email protected]



Commits

4e5b88e Merge pull request #812 from uuid-rs/cargo/v1.15.1
7fb64f7 prepare for 1.15.1 release
f05b6df Merge pull request #811 from uuid-rs/fix/v7-overflow
c2d313f guarantee v7 timestamp will never overflow
See full diff in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant