Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seq: Eliminated special handling of -0.0 #3056

Merged
merged 1 commit into from
Feb 17, 2022
Merged

seq: Eliminated special handling of -0.0 #3056

merged 1 commit into from
Feb 17, 2022

Conversation

palaster
Copy link
Contributor

@palaster palaster commented Feb 4, 2022 •
edited
Loading

This PR addresses #2870
Removed special format handling around -0.0 in seq

palaster
palaster commented Feb 4, 2022
View reviewed changes
@palaster palaster changed the title seq: Elimated special handling of -0.0 seq: Eliminated special handling of -0.0 Feb 5, 2022
@sylvestre
Copy link
Contributor

Could you please add a test to make sure we don't regress? thanks

@palaster
Copy link
Contributor Author

palaster commented Feb 8, 2022 •
edited
Loading

In test_seq they're these tests:
test_width_negative_zero_decimal_notation
test_negative_zero_int_start_float_increment
that already check for -0.0

@tertsdiepraam tertsdiepraam merged commit b082b98 into uutils:main Feb 17, 2022
@palaster palaster deleted the fix-issue-2870 branch February 18, 2022 00:36
@palaster palaster mentioned this pull request Feb 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfinkels jfinkels jfinkels left review comments

@tertsdiepraam tertsdiepraam Awaiting requested review from tertsdiepraam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@palaster @sylvestre @jfinkels @tertsdiepraam