expr: Add tests #7356
Open
expr: Add tests #7356
+895
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenjiSann
force-pushed
the
expr-fixes
branch
from
481a155 to
11931ab
Compare
sylvestre
reviewed
Feb 25, 2025
| @@ -1834,6 +1834,14 @@ impl UCommand { | |||
| cmd_result | |||
| } | |||
|
|
|||
| #[track_caller] | |||
| pub fn fails_with_code(&mut self, expected_code: i32) -> CmdResult { | |||
There was a problem hiding this comment.
why this function?
you can do
.fails().code_is(1)
There was a problem hiding this comment.
I find it to be faster to write (it only takes 1 LSP completion, which loads in 3-4 seconds on my machine), and takes 1 line less after formatting.
Considering the fact I had to replicate it around 30 times last evening, I thought it was worth adding, but obviously that's not a strong requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rewritten all the GNU testcases of
gnu/tests/expr/expr.plin our testsuite, to more easily track potential regressions.Sadly, the remaining issues are all caused by our regex dependency (
rust-onig) which has a diverging behavior from GNU. This emphasizes the need to find another regex engine, as discussed in #1145