-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pgrep/pkill/pidwait: Support --uid, --euid & --group options #332
Conversation
Don't leak intricate details of Linux procfs internals.
Many arguments in pgrep/pkill/pidwait take list as an option and can be handled in an unified way.
0cd81a1
to
29467aa
Compare
Resolving user/group names requires enabling "entries" feature in uucore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you sync the changes of process.rs
into https://github.com/uutils/coreutils/blob/main/src/uucore/src/lib/features/process.rs? This file will be migrated into uucore
in future :)
Added here: uutils/coreutils#7351 Is there some timeline for the migration? Probably makes sense to get the process module in procps as complete as possible before migration, as it will make considerably more difficult to add new features to procps (as then new features might need to wait for uucore to make a release) |
If possible, the migration will start when tools that depend on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
No description provided.