Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgrep/pkill/pidwait: Support --uid, --euid & --group options #332

Merged
merged 6 commits into from
Feb 26, 2025

Conversation

dezgeg
Copy link
Contributor

@dezgeg dezgeg commented Feb 23, 2025

No description provided.

Don't leak intricate details of Linux procfs internals.
Many arguments in pgrep/pkill/pidwait take list as an option and
can be handled in an unified way.
@dezgeg dezgeg force-pushed the uids branch 2 times, most recently from 0cd81a1 to 29467aa Compare February 23, 2025 01:50
Resolving user/group names requires enabling "entries" feature in
uucore.
Copy link
Collaborator

@Krysztal112233 Krysztal112233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sync the changes of process.rs into https://github.com/uutils/coreutils/blob/main/src/uucore/src/lib/features/process.rs? This file will be migrated into uucore in future :)

@dezgeg
Copy link
Contributor Author

dezgeg commented Feb 24, 2025

Could you sync the changes of process.rs into https://github.com/uutils/coreutils/blob/main/src/uucore/src/lib/features/process.rs? This file will be migrated into uucore in future :)

Added here: uutils/coreutils#7351

Is there some timeline for the migration? Probably makes sense to get the process module in procps as complete as possible before migration, as it will make considerably more difficult to add new features to procps (as then new features might need to wait for uucore to make a release)

@Krysztal112233
Copy link
Collaborator

Krysztal112233 commented Feb 25, 2025

Is there some timeline for the migration?

If possible, the migration will start when tools that depend on pgrep are almost available. Actually I don't know the timeline although it was planned last year by me :(. So just continue your work and I will make pull request to do this job before migration.

@cakebaker cakebaker merged commit 4a88d69 into uutils:main Feb 26, 2025
14 checks passed
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (2e5bbed) to head (ef22c48).
Report is 12 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #332   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cakebaker
Copy link
Contributor

@dezgeg thanks!

Regarding moving process.rs to coreutils: currently I don't see what the benefit is. And I agree with @dezgeg that it would make working on this project rather inflexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants