fix: use time-constant comparison for CSRF tokens #12188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected.
TatuLund
added a commit
that referenced
this pull request
Jan 28, 2021
This is the same as #12188, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role.
|
Picked from: vaadin/flow@292b3a0 |
Ansku
pushed a commit
that referenced
this pull request
Jan 29, 2021
This is the same as #12188, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role. Cherry-picked from: vaadin/flow#9896
Ansku
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Hey! when are you planning to release this? |
@AdamGold in the best possible speed. |
Ansku
pushed a commit
that referenced
this pull request
Feb 3, 2021
This is the same as #12188, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role. Cherry-picked from: vaadin/flow#9896
Ansku
added a commit
that referenced
this pull request
Feb 3, 2021
This is the same as #12188, but also applied for the upload security key and the push id since both of those are also used to protect against cross-site attacks. In addition, documentation for the push id is clarified to point out its role. Cherry-picked from: vaadin/flow#9896 Authored-by: Tatu Lund <[email protected]>
Ansku
pushed a commit
that referenced
this pull request
Feb 3, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. Cherry-picked from: vaadin/flow#9875
Ansku
added a commit
that referenced
this pull request
Feb 3, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. Cherry-picked from: vaadin/flow#9875 Authored-by: Tatu Lund <[email protected]>
Ansku
pushed a commit
that referenced
this pull request
Feb 4, 2021
This hardens the framework against a theoretical timing attack based on comparing how quickly a request with an invalid CSRF token is rejected. Backporting of #12188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hardens the framework against a theoretical timing attack based on
comparing how quickly a request with an invalid CSRF token is rejected.
This change is