feat: support search and hash strings in Router.go #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platosha
force-pushed
the
feat/go-to-url
branch
from
9b18ada to
b89bee9
Compare
manolo
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
Linter errors
Reviewed 12 of 12 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Connected to #56
platosha
force-pushed
the
feat/go-to-url
branch
from
b89bee9 to
832b282
Compare
platosha
commented
Oct 3, 2019
There was a problem hiding this comment.
@manolo oops, always forget that. Fixed!
Reviewable status: 10 of 12 files reviewed, all discussions resolved (waiting on @manolo)
manolo
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #56
This change is