fix: use es2021 as a target for TypeScript #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platosha
requested changes
Nov 7, 2024
test/resolver/resolver.spec.ts
Outdated
Comment on lines
92
to
93
| expect(error.cause).to.be.an('error'); | ||
| expect(error.cause).to.have.property('message').that.equals('custom'); |
There was a problem hiding this comment.
Let's keep the assertion and add the cause back somehow.
There was a problem hiding this comment.
Should I just provide that es2022 TS code here then? As a kind of TS polyfill?
There was a problem hiding this comment.
I think, restoring cause as a custom property in ResolutionError is a good option.
platosha
approved these changes
Nov 7, 2024
test/resolver/resolver.spec.ts
Outdated
Comment on lines
92
to
93
| expect(error.cause).to.be.an('error'); | ||
| expect(error.cause).to.have.property('message').that.equals('custom'); |
There was a problem hiding this comment.
I think, restoring cause as a custom property in ResolutionError is a good option.
Lodin
added a commit
that referenced
this pull request
Nov 13, 2024
* fix: use es2021 as a target for TypeScript * fix: get rid of es2022 code * fix: restore error.cause --------- Co-authored-by: Anton Platonov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #897