fix: only send IDONTWANT to mesh peers #1261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
requested review from
arnetheduck,
kaiserd,
vladopajic and
ufarooqstatus
|
hm, interesting conundrum .. if they have us as a direct peer, we want to send IDONTWANT to them to avoid getting a redundant copy - I don't remember if we announce the direct-ness to the other party the same way we understand their participation in the mesh. Ditto fanout, could we somehow anticipate if they are about to send us a message as part of their fanout? I guess not, but ... |
richard-ramos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specs, IDONTWANT messages should be sent to mesh peers, and does not specify that fanout peers and direct peers should also receive this type of message.
cc: @AkshayaMani