chore(protocols): specify raised exceptions (part 2)

[vladopajic]

this PR specifies raised exceptions in protocols module. it is part 2, continuation to #1260.

part of #962 effort.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 97.26027% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (raises-protocol-handler-no@eca8bb1). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
libp2p/protocols/connectivity/autonat/client.nim	97.14%	1 Missing ⚠️
libp2p/services/hpservice.nim	92.30%	1 Missing ⚠️

Additional details and impacted files

@@                      Coverage Diff                      @@
##             raises-protocol-handler-no    #1268   +/-   ##
=============================================================
  Coverage                              ?   84.55%           
=============================================================
  Files                                 ?       93           
  Lines                                 ?    16930           
  Branches                              ?        0           
=============================================================
  Hits                                  ?    14315           
  Misses                                ?     2615           
  Partials                              ?        0           

Files with missing lines	Coverage Δ
libp2p/connmanager.nim	92.60% <ø> (ø)
libp2p/protocols/connectivity/autonat/server.nim	81.95% <ø> (ø)
libp2p/protocols/connectivity/autonat/service.nim	97.48% <100.00%> (ø)
libp2p/protocols/connectivity/dcutr/client.nim	76.78% <100.00%> (ø)
libp2p/protocols/connectivity/dcutr/core.nim	100.00% <100.00%> (ø)
libp2p/protocols/connectivity/relay/relay.nim	82.18% <100.00%> (ø)
libp2p/protocols/identify.nim	82.68% <100.00%> (ø)
libp2p/protocols/pubsub/pubsub.nim	85.00% <100.00%> (ø)
libp2p/protocols/rendezvous.nim	74.76% <100.00%> (ø)
libp2p/services/autorelayservice.nim	97.41% <100.00%> (ø)
... and 2 more

[richard-ramos]

Curious about the exception being generated here. Do you think it's worth it to add a trace log?

[vladopajic]

i internationally didn't wanted to add log there, as compiler tells that AlreadyExpectingConnectionError can happen here, but, if this error happens it will happen only right after switch.connManager.expectConnection(pid, In) is called and that case is already handled. however i have added comment (to explain) and error log (it should never happen tho)