Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add lockup tests #5

Merged
merged 2 commits into from
Oct 9, 2024
Merged

test: add lockup tests #5

merged 2 commits into from
Oct 9, 2024

Conversation

0x-r4bbit
Copy link
Collaborator

No description provided.

@0x-r4bbit 0x-r4bbit force-pushed the lockup-tests branch 2 times, most recently from aeb8d72 to bcf54bc Compare September 25, 2024 08:05
@0x-r4bbit
Copy link
Collaborator Author

@gravityblast ping

@0x-r4bbit 0x-r4bbit changed the base branch from add-tests to main October 9, 2024 09:36
@0x-r4bbit
test: add lockup tests
b93c66b 
Closes #3
@0x-r4bbit
fix: improve precision loss when unstaking and add testso
2970e96 
This commit changes the calculation for when MPs are reduced globally
and for the user that is unstaking.

Instead of getting an `amountRatio` first and using that the
multiplication, we're now applying the `SCALE_FACTOR` to both, the
numerator and denominator to maintain the ratio while increasing
precision.
@0x-r4bbit 0x-r4bbit merged commit 0af58f9 into main Oct 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravityblast gravityblast gravityblast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x-r4bbit @gravityblast