Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NAT traversal open problem #86

Merged
merged 2 commits into from
Aug 17, 2022
Merged

add NAT traversal open problem #86

merged 2 commits into from
Aug 17, 2022

Conversation

kaiserd
Copy link
Contributor

@kaiserd kaiserd commented Aug 17, 2022

This PR adds a NAT traversal open problem to the open problems page.

Disclaimer:

It would make sense to have ICE options exhausted and implemented,
and then identify which open problems still remain.
This is why in its current state, the topic comprises the integration of ICE, too.
If we want to have a pure research problems, we should keep this topic on hold until whe have an ICE integration and better knowledge of what we actually need.

We could also add browser connectivity as part of the "Robust P2P" topic.

cc @jm-clius

@kaiserd kaiserd requested review from oskarth and staheri14 August 17, 2022 10:16
@kaiserd kaiserd mentioned this pull request Aug 17, 2022
6 tasks
Copy link
Contributor

@jm-clius jm-clius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor suggestion to have the focus be on the more general research area, while mentioning the ICE implementation as a subordinate clause :)

open-problems.md Outdated
Comment on lines 53 to 54
This topic comprises integrating and specifying ICE for [Waku v2](https://rfc.vac.dev/spec/10/),
as well as researching novel complementary NAT traversal techniques that are decentralized and have desirable privacy and anonymity properties.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get that we need ICE before researching more novel techniques, but perhaps this formulation could focus on the latter and mention the ICE implementation as secondary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thats much better. Updated in c00d383.

I also added some info on the current state of Waku NAT traversal to provide more context. Wdyt @jm-clius?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@oskarth oskarth requested a review from kdeme August 17, 2022 12:56
@kaiserd kaiserd merged commit 355708f into staging Aug 17, 2022
@kaiserd kaiserd deleted the add/open-problems-NAT branch August 17, 2022 13:18
@kaiserd kaiserd mentioned this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants