test: separate out tests #103
Conversation
There was a problem hiding this comment.
We should agree on a standard way to name tests. I think the most straightforward is to have the test source with same name as the logic source the tests refer to, rather than introducing new names (e.g. basic).
According to the above, it would also be great if there is no lib.rs under tests, in the sense that the tests that are currently present there (e.g. rln, semaphore) should be moved to/merged with tests with creates where such functionalities are implemented (e.g. semaphore/lib tests should be moved under tests/protocol.rs, etc.)
Also I see tests in rln/public were not moved and also some other ones.
rahulghangas
force-pushed
the
test/separate-tests
branch
from
708730e to
70390ef
Compare
There was a problem hiding this comment.
Great PR! LGTM!
The only test I see should still be moved is https://github.com/vacp2p/zerokit/blob/test/separate-tests/semaphore/src/protocol.rs#L217, please do it before merging.
|
Whoops, missed that. Will refactor |
Move tests to standalone
testsdirectory in each submodule