Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement qps control for benchmark using token bucket algorithm #1761

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

artikell
Copy link
Contributor

Implemented a benchmark for constant QPS through token bucket algorithm.

The bench program originally used a lot of CPUs, Control speed through the usleep method, rather than AE events.

refer to #1201

@artikell artikell force-pushed the feat/benchmark_with_qps branch 2 times, most recently from fd0fd1a to baa01cc Compare February 21, 2025 14:34
@artikell artikell force-pushed the feat/benchmark_with_qps branch from baa01cc to cbca6a5 Compare February 21, 2025 14:38
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 15.15152% with 28 lines in your changes missing coverage. Please review.

Project coverage is 71.07%. Comparing base (206f7f6) to head (cbca6a5).
Report is 4 commits behind head on unstable.

Files with missing lines Patch % Lines
src/valkey-benchmark.c 15.15% 28 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1761      +/-   ##
============================================
- Coverage     71.14%   71.07%   -0.07%     
============================================
  Files           123      123              
  Lines         65534    65585      +51     
============================================
- Hits          46622    46617       -5     
- Misses        18912    18968      +56     
Files with missing lines Coverage Δ
src/valkey-benchmark.c 60.50% <15.15%> (-1.25%) ⬇️

... and 19 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant