Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework MustacheContext #64

Merged
merged 46 commits into from
Jun 13, 2017
Merged

Rework MustacheContext #64

merged 46 commits into from
Jun 13, 2017

Conversation

valotas
Copy link
Owner

@valotas valotas commented Jun 4, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9ddd00c on issue62/dart2js into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 275cbc8 on issue62/dart2js into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6a8e2ea on issue62/dart2js into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 91589e7 on issue62/dart2js into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c0d4a82 on issue62/dart2js into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fea1652 on issue62/dart2js into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4c45ec7 on issue62/dart2js into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0aea79e on issue62/dart2js into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 454cf59 on issue62/dart2js into ** on master**.

@valotas
Copy link
Owner Author

valotas commented Jun 12, 2017

@jcollins-g do you mind testing against this branch? I had to rework the mirrors in order to make some cases work better with dartjs. There is no exception trapping happening though, so in theory performance should be just like before.

@jcollins-g
Copy link
Contributor

@valotas Tried with the branch, not seeing the bad performance characteristics from pre 1.1.0 and performance seems just as fast as before.

@valotas
Copy link
Owner Author

valotas commented Jun 13, 2017

Thanks! baking a new version then

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1a70b33 on issue62/dart2js into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7c79ea9 on issue62/dart2js into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d1281ee on issue62/dart2js into ** on master**.

@valotas valotas merged commit 33da62f into master Jun 13, 2017
@valotas valotas deleted the issue62/dart2js branch April 14, 2018 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants