Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revalidate Header Updates #57162

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Revalidate Header Updates #57162

merged 2 commits into from
Oct 23, 2023

Conversation

wyattjoh
Copy link
Member

@wyattjoh wyattjoh commented Oct 21, 2023

Update the revalidate handling to perform the revalidate option coalescing in the render function closer to the render result output. This helps reduce the amount of scope leak from the render.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 21, 2023
@wyattjoh
Copy link
Member Author

wyattjoh commented Oct 21, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@ijjk
Copy link
Member

ijjk commented Oct 21, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 21, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js refactor/revalidate Change
buildDuration 11.9s 12s ⚠️ +121ms
buildDurationCached 6.9s 6.7s N/A
nodeModulesSize 174 MB 174 MB N/A
nextStartRea..uration (ms) 432ms 424ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js refactor/revalidate Change
199-HASH.js gzip 27.9 kB 27.9 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 33 kB 33 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js refactor/revalidate Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js refactor/revalidate Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js refactor/revalidate Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js refactor/revalidate Change
index.html gzip 528 B 529 B N/A
link.html gzip 541 B 541 B
withRouter.html gzip 523 B 522 B N/A
Overall change 541 B 541 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js refactor/revalidate Change
edge-ssr.js gzip 95.7 kB 95.3 kB N/A
page.js gzip 158 kB 158 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js refactor/revalidate Change
middleware-b..fest.js gzip 623 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Diff details
Diff for page.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Commit: c70b295

@wyattjoh wyattjoh force-pushed the feat/normalizer-updates branch from b2d2160 to 9446089 Compare October 21, 2023 22:09
@wyattjoh wyattjoh force-pushed the refactor/revalidate branch from 28f5b38 to 8305241 Compare October 22, 2023 00:41
@wyattjoh wyattjoh force-pushed the feat/normalizer-updates branch from 9446089 to 87a71ca Compare October 22, 2023 06:38
@wyattjoh wyattjoh force-pushed the refactor/revalidate branch 2 times, most recently from 84d0040 to 55e7c39 Compare October 22, 2023 21:41
@wyattjoh wyattjoh force-pushed the feat/normalizer-updates branch from 87a71ca to eb1dbcd Compare October 22, 2023 21:58
@wyattjoh wyattjoh force-pushed the refactor/revalidate branch from 55e7c39 to 6438bd0 Compare October 22, 2023 21:59
@wyattjoh wyattjoh force-pushed the feat/normalizer-updates branch from eb1dbcd to 3b59dbf Compare October 23, 2023 16:57
Base automatically changed from feat/normalizer-updates to canary October 23, 2023 18:25
@wyattjoh wyattjoh force-pushed the refactor/revalidate branch 2 times, most recently from eb58ca8 to 6e909cc Compare October 23, 2023 18:41
@wyattjoh wyattjoh marked this pull request as ready for review October 23, 2023 18:41
@wyattjoh wyattjoh mentioned this pull request Oct 23, 2023
@wyattjoh wyattjoh force-pushed the refactor/revalidate branch from 6e909cc to a90d627 Compare October 23, 2023 19:17
@kodiakhq kodiakhq bot merged commit f154bb8 into canary Oct 23, 2023
@kodiakhq kodiakhq bot deleted the refactor/revalidate branch October 23, 2023 19:37
@wyattjoh wyattjoh mentioned this pull request Oct 23, 2023
@github-actions github-actions bot added the locked label Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants